Skip to content
  1. Nov 02, 2007
  2. Nov 01, 2007
    • Neil Booth's avatar
      Add back line whose removal somehow crept into prior patch · ae077d23
      Neil Booth authored
      llvm-svn: 43627
      ae077d23
    • Neil Booth's avatar
      When converting to integer, do bit manipulations in the destination · 618d0fc3
      Neil Booth authored
      memory rather than in a copy of the APFloat.  This avoids problems
      when the destination is wider than our significand and is cleaner.
      
      Also provide deterministic values in all cases where conversion
      fails, namely zero for NaNs and the minimal or maximal value
      respectively for underflow or overflow.
      
      llvm-svn: 43626
      618d0fc3
    • Ted Kremenek's avatar
      Removed ReadVal from SerializeTrait<T>, and also removed it from · 478c6982
      Ted Kremenek authored
      Deserializer.
      
      There were issues with Visual C++ barfing when instantiating
      SerializeTrait<T> when "T" was an abstract class AND
      SerializeTrait<T>::ReadVal was *never* called:
      
      template <typename T>
      struct SerializeTrait {
       <SNIP>
        static inline T ReadVal(Deserializer& D) { T::ReadVal(D); }
       <SNIP>
      };
      
      Visual C++ would complain about "T" being an abstract class, even
      though ReadVal was never instantiated (although one of the other
      member functions were).
      
      Removing this from the trait is not a big deal.  It was used hardly
      ever, and users who want "read-by-value" deserialization can simply
      call the appropriate methods directly instead of relying on
      trait-based-dispatch.  The trait dispatch for
      serialization/deserialization is simply sugar in many cases (like this
      one).
      
      llvm-svn: 43624
      478c6982
    • Duncan Sands's avatar
      Executive summary: getTypeSize -> getTypeStoreSize / getABITypeSize. · 44b8721d
      Duncan Sands authored
      The meaning of getTypeSize was not clear - clarifying it is important
      now that we have x86 long double and arbitrary precision integers.
      The issue with long double is that it requires 80 bits, and this is
      not a multiple of its alignment.  This gives a primitive type for
      which getTypeSize differed from getABITypeSize.  For arbitrary precision
      integers it is even worse: there is the minimum number of bits needed to
      hold the type (eg: 36 for an i36), the maximum number of bits that will
      be overwriten when storing the type (40 bits for i36) and the ABI size
      (i.e. the storage size rounded up to a multiple of the alignment; 64 bits
      for i36).
      
      This patch removes getTypeSize (not really - it is still there but
      deprecated to allow for a gradual transition).  Instead there is:
      
      (1) getTypeSizeInBits - a number of bits that suffices to hold all
      values of the type.  For a primitive type, this is the minimum number
      of bits.  For an i36 this is 36 bits.  For x86 long double it is 80.
      This corresponds to gcc's TYPE_PRECISION.
      
      (2) getTypeStoreSizeInBits - the maximum number of bits that is
      written when storing the type (or read when reading it).  For an
      i36 this is 40 bits, for an x86 long double it is 80 bits.  This
      is the size alias analysis is interested in (getTypeStoreSize
      returns the number of bytes).  There doesn't seem to be anything
      corresponding to this in gcc.
      
      (3) getABITypeSizeInBits - this is getTypeStoreSizeInBits rounded
      up to a multiple of the alignment.  For an i36 this is 64, for an
      x86 long double this is 96 or 128 depending on the OS.  This is the
      spacing between consecutive elements when you form an array out of
      this type (getABITypeSize returns the number of bytes).  This is
      TYPE_SIZE in gcc.
      
      Since successive elements in a SequentialType (arrays, pointers
      and vectors) need to be aligned, the spacing between them will be
      given by getABITypeSize.  This means that the size of an array
      is the length times the getABITypeSize.  It also means that GEP
      computations need to use getABITypeSize when computing offsets.
      Furthermore, if an alloca allocates several elements at once then
      these too need to be aligned, so the size of the alloca has to be
      the number of elements multiplied by getABITypeSize.  Logically
      speaking this doesn't have to be the case when allocating just
      one element, but it is simpler to also use getABITypeSize in this
      case.  So alloca's and mallocs should use getABITypeSize.  Finally,
      since gcc's only notion of size is that given by getABITypeSize, if
      you want to output assembler etc the same as gcc then getABITypeSize
      is the size you want.
      
      Since a store will overwrite no more than getTypeStoreSize bytes,
      and a read will read no more than that many bytes, this is the
      notion of size appropriate for alias analysis calculations.
      
      In this patch I have corrected all type size uses except some of
      those in ScalarReplAggregates, lib/Codegen, lib/Target (the hard
      cases).  I will get around to auditing these too at some point,
      but I could do with some help.
      
      Finally, I made one change which I think wise but others might
      consider pointless and suboptimal: in an unpacked struct the
      amount of space allocated for a field is now given by the ABI
      size rather than getTypeStoreSize.  I did this because every
      other place that reserves memory for a type (eg: alloca) now
      uses getABITypeSize, and I didn't want to make an exception
      for unpacked structs, i.e. I did it to make things more uniform.
      This only effects structs containing long doubles and arbitrary
      precision integers.  If someone wants to pack these types more
      tightly they can always use a packed struct.
      
      llvm-svn: 43620
      44b8721d
    • Duncan Sands's avatar
      Don't barf on empty basic blocks. Do not rely on assert · e0e774b6
      Duncan Sands authored
      doing something - this needs to work for release builds
      too.  I chose to just abort rather than following the
      fancy logic of abortIfBroken, because (1) it is a pain
      to do otherwise, and (2) nothing is going to work if the
      module is this broken.
      
      llvm-svn: 43611
      e0e774b6
    • Bill Wendling's avatar
      Silence a warning saying that the variables always resolve to "true" in an · 87f460f8
      Bill Wendling authored
      expression.
      
      llvm-svn: 43610
      87f460f8
    • Bill Wendling's avatar
      Silence, accersed warning · b7cabbe2
      Bill Wendling authored
      llvm-svn: 43609
      b7cabbe2
    • Evan Cheng's avatar
      - Coalesce extract_subreg when both intervals are relatively small. · fe1ac528
      Evan Cheng authored
      - Some code clean up.
      
      llvm-svn: 43606
      fe1ac528
    • Owen Anderson's avatar
      Fix test/Transforms/DeadStoreElimination/PartialStore.ll, which had been · 2ed651ac
      Owen Anderson authored
      silently failing because of an incorrect run line for some time.
      
      llvm-svn: 43605
      2ed651ac
    • Chris Lattner's avatar
      remove verifier command line option: this should be part of the API, not · dff7a3e9
      Chris Lattner authored
      a command line optn.
      
      llvm-svn: 43603
      dff7a3e9
    • Owen Anderson's avatar
      Now with less tabs! · fe41d791
      Owen Anderson authored
      llvm-svn: 43601
      fe41d791
    • Chris Lattner's avatar
      Fix InstCombine/2007-10-31-StringCrash.ll by removing an obvious · 6ab19ed7
      Chris Lattner authored
      (in hindsight) infinite recursion.  Simplify the code.
      
      llvm-svn: 43597
      6ab19ed7
    • Chris Lattner's avatar
      Fix InstCombine/2007-10-31-RangeCrash.ll · 74709473
      Chris Lattner authored
      llvm-svn: 43596
      74709473
    • Ted Kremenek's avatar
      Rewrote backpatcher. Backpatcher now stores the "has final pointer" · fb764e52
      Ted Kremenek authored
      flag in the **key** of the backpatch map, as opposed to the mapped
      value which contains either the final pointer, or a pointer to a chain
      of pointers that need to be backpatched.  The bit flag was moved to
      the key because we were erroneously assuming that the backpatched
      pointers would be at an alignment of >= 2 bytes, which obviously
      doesn't work for character strings.  Now we just steal the bit from the key.
      
      llvm-svn: 43595
      fb764e52
  3. Oct 31, 2007
  4. Oct 30, 2007
Loading