[LangRef] Fix description of shape args for matrix.multiply.
Currently all code instances within the matrix lowering pass consider matrix A to be MxN and B to be NxK, producing C which is MxK. Anyone interacting with this API after reading the docs but without reading the pass would expect A: MxK, B: KxN, and C: MxN. These changes bring the documentation in line with the implementation. One point of concern with this, the original signature as described in the docs may be better or at least more expected. The interface as it was written reflected other common matrix multiplication interfaces such as BLAS'[1], where the matrices are MxK, KxN, MxN respectively. Choosing to honor this requires changing code and tests instead, but should be mostly just renaming of variables. Patch by Braedy Kuzma <braedy@ualberta.ca> [1] http://www.netlib.org/lapack/explore-html/db/dc9/group__single__blas__level3_gafe51bacb54592ff5de056acabd83c260.html#gafe51bacb54592ff5de056acabd83c260 Reviewers: anemet, LuoYuanke, nicolasvasilache, fhahn Reviewed By: fhahn Differential Revision: https://reviews.llvm.org/D80663
Loading
Please sign in to comment