Skip to content
  1. Jun 03, 2021
  2. Jun 02, 2021
  3. Jun 01, 2021
  4. May 31, 2021
  5. May 28, 2021
  6. May 27, 2021
  7. May 26, 2021
  8. May 25, 2021
  9. May 24, 2021
    • Uday Bondhugula's avatar
      [MLIR] Make MLIR cmake variable names consistent · 9c21ddb7
      Uday Bondhugula authored
      Fix inconsistent MLIR CMake variable names. Consistently name them as
      MLIR_ENABLE_<feature>.
      
      Eg: MLIR_CUDA_RUNNER_ENABLED -> MLIR_ENABLE_CUDA_RUNNER
      
      MLIR follows (or has mostly followed) the convention of naming
      cmake enabling variables in the from MLIR_ENABLE_... etc. Using a
      convention here is easy and also important for convenience. A counter
      pattern was started with variables named MLIR_..._ENABLED. This led to a
      sequence of related counter patterns: MLIR_CUDA_RUNNER_ENABLED,
      MLIR_ROCM_RUNNER_ENABLED, etc.. From a naming standpoint, the imperative
      form is more meaningful. Additional discussion at:
      https://llvm.discourse.group/t/mlir-cmake-enable-variable-naming-convention/3520
      
      Switch all inconsistent ones to the ENABLE form. Keep the couple of old
      mappings needed until buildbot config is migrated.
      
      Differential Revision: https://reviews.llvm.org/D102976
      9c21ddb7
  10. May 23, 2021
  11. May 22, 2021
  12. May 21, 2021
Loading