Skip to content
  1. Jun 03, 2021
  2. Jun 02, 2021
  3. Jun 01, 2021
  4. May 27, 2021
  5. May 26, 2021
  6. May 21, 2021
  7. May 20, 2021
  8. May 19, 2021
  9. May 17, 2021
  10. May 15, 2021
  11. May 14, 2021
  12. May 13, 2021
  13. May 12, 2021
  14. May 11, 2021
  15. May 08, 2021
    • River Riddle's avatar
      [mlir] Refactor the representation of function-like argument/result attributes. · 53b946aa
      River Riddle authored
      The current design uses a unique entry for each argument/result attribute, with the name of the entry being something like "arg0". This provides for a somewhat sparse design, but ends up being much more expensive (from a runtime perspective) in-practice. The design requires building a string every time we lookup the dictionary for a specific arg/result, and also requires N attribute lookups when collecting all of the arg/result attribute dictionaries.
      
      This revision restructures the design to instead have an ArrayAttr that contains all of the attribute dictionaries for arguments and another for results. This design reduces the number of attribute name lookups to 1, and allows for O(1) lookup for individual element dictionaries. The major downside is that we can end up with larger memory usage, as the ArrayAttr contains an entry for each element even if that element has no attributes. If the memory usage becomes too problematic, we can experiment with a more sparse structure that still provides a lot of the wins in this revision.
      
      This dropped the compilation time of a somewhat large TensorFlow model from ~650 seconds to ~400 seconds.
      
      Differential Revision: https://reviews.llvm.org/D102035
      53b946aa
  16. May 07, 2021
Loading