Commits · 72c0b1cc1b9d012a315448ac1e6d87f6977af731 · Lorenzo Albano / LLVM bpEVL

Jul 27, 2017

Fix assert from r309278 · 72c0b1cc
David Blaikie authored Jul 27, 2017
```
llvm-svn: 309281
```
72c0b1cc
remove redundant check · 960e7663
Adrian Prantl authored Jul 27, 2017
```
llvm-svn: 309280
```
960e7663

ThinLTO: Don't import aliases of any kind (even linkonce_odr) · 2f0cc477

David Blaikie authored Jul 27, 2017

Summary:
Until a more advanced version of importing can be implemented for
aliases (one that imports an alias as an available_externally definition
of the aliasee), skip the narrow subset of cases that was possible but
came at a cost: aliases of linkonce_odr functions could be imported
because the linkonce_odr function could be safely duplicated from the
source module. This came/comes at the cost of not being able to 'home'
imported linkonce functions (they had to be emitted linkonce_odr in all
the destination modules (even if they weren't used by an alias) rather
than as available_externally - causing extra object size).

Tangentially, this also was the only reason ThinLTO would emit multiple
CUs in to the resulting DWARF - which happens to be a problem for
Fission (there's a fix for this in GDB but not released yet, etc).
(actually it's not the only reason - but I'm sending a patch to fix the
other reason shortly)

There's no reason to believe this particularly narrow alias importing
was especially/meaningfully important, only that it was /possible/ to
implement in this way. When a more general solution is done, it should
still satisfy the DWARF concerns above, since the import will still be
available_externally, and thus not create extra CUs.

Since now all aliases are treated the same, I removed/simplified some
test cases since they were testing corner cases where there are no
longer any corners.

Reviewers: tejohnson, mehdi_amini

Differential Revision: https://reviews.llvm.org/D35875

llvm-svn: 309278

2f0cc477

[SelectionDAG] Tidyup mask creation. NFCI. · 0d543b59

Simon Pilgrim authored Jul 27, 2017

Assign all concat elements to UNDEF and then just replace the first element, instead of copying everything individually.

llvm-svn: 309277

0d543b59

[clang-diff] Rename, NFC · 914a958e
Johannes Altmanninger authored Jul 27, 2017
```
llvm-svn: 309276
```
914a958e

Update isl to isl-0.18-800-g4018f45 · adcbee54

Tobias Grosser authored Jul 27, 2017

This fixes a bug in isl_flow where triggering the compute out could result in
undefined or unexpected behavior. This fixes some recent regressions we saw
in the android buildbots. Thanks Eli Friedman for reducing the corresponding
test cases.

llvm-svn: 309274

adcbee54

[ScopBuilder/Simplify] Refactor isEscaping. NFC. · a508a4e6

Michael Kruse authored Jul 27, 2017

ScopBuilder and Simplify (through VirtualInstruction.cpp) previously
used this functionality in their own implementation. Refactor them
both into a common one into the Scop class.

BlockGenerator also makes use of a similiar functionality, but also
records outside users and takes place after region simplification.
Merging it as well would be more complicated.

llvm-svn: 309273

a508a4e6

[ARM] Mark labels in skipAlignedDPRCS2Spills as fallthrough (NFC). · db479524

Florian Hahn authored Jul 27, 2017

The comment at the top of the switch statement indicates that the
fall-through behavior is intentional. By using LLVM_FALLTHROUGH,
-Wimplicit-fallthrough are silenced, which is enabled by default in GCC
7.

llvm-svn: 309272

db479524

[Simplify] Count PHINodes in simplifiable exit nodes as escaping use. · 8a8aca42

Michael Kruse authored Jul 27, 2017

After region exit simplification, the incoming block of a phi node in
the SCoP region's exit block lands outside of the region. Since we
treat SCoPs as if this already happened, we need to account for that
when looking for outside uses of scalars (i.e. escaping scalars).

llvm-svn: 309271

8a8aca42

[OPENMP] Codegen for 'in_reduction' clause. · 88202be1

Alexey Bataev authored Jul 27, 2017

Added codegen for task-based directive with in_reduction clause.
```
<body>
```
The next code is emitted:
```
void *td;
...
td = call i8* @__kmpc_task_reduction_init();
...
<type> *priv = (<type> *)call i8* @__kmpc_task_reduction_get_th_data(i32
GTID, i8* td, i8* <orig>)
```

llvm-svn: 309270

88202be1

Added cost of ZEROALL and ZEROUPPER instrs in btver2 cpu. · e255526d
Andrew V. Tischenko authored Jul 27, 2017
```
Differential Revision https://reviews.llvm.org/D35834

llvm-svn: 309269
```
e255526d

[InlineCost, NFC] Change CallAnalyzer::isGEPFree to use TTI::getUserCost instead of TTI::getGEPCost · 61c1bd5a

Evgeny Astigeevich authored Jul 27, 2017

Currently CallAnalyzer::isGEPFree uses TTI::getGEPCost to check if GEP is free.
TTI::getGEPCost cannot handle cases when GEPs participate in Def-Use dependencies
(see https://reviews.llvm.org/D31186 for example).
There is TTI::getUserCost which can calculate the cost more accurately by
taking dependencies into account.

Differential Revision: https://reviews.llvm.org/D33685

llvm-svn: 309268

61c1bd5a

[globalisel][tablegen] Ensure MatchTable's are compile-time constants with constexpr. NFC. · cbbbfe40
Daniel Sanders authored Jul 27, 2017
```
This should prevent any re-occurence of the problem where the table was
initialized at run-time.

llvm-svn: 309267
```
cbbbfe40
[X86][AVX] Regenerate shuffle tests with broadcast comments. · 31f54027
Simon Pilgrim authored Jul 27, 2017
```
llvm-svn: 309266
```
31f54027
XFAIL/XFlakey some tests what become very flakey on the Linux buildbot · b3ad17fb
Tamas Berghammer authored Jul 27, 2017
```
llvm-svn: 309265
```
b3ad17fb

Re-commit: r309094 [globalisel][tablegen] Fuse the generated tables together. · 8e82af2b

Daniel Sanders authored Jul 27, 2017

Summary:
Now that we have control flow in place, fuse the per-rule tables into a
single table. This is a compile-time saving at this point. However, this will
also enable the optimization of a table so that similar instructions can be
tested together, reducing the time spent on the matching the code.

This is NFC in terms of externally visible behaviour but some internals have
changed slightly. State.MIs is no longer reset between each rule that is
attempted because it's not necessary to do so. As a consequence of this the
restriction on the order that instructions are added to State.MIs has been
relaxed to only affect recorded instructions that require new elements to be
added to the vector. GIM_RecordInsn can now write to any element from 1 to
State.MIs.size() instead of just State.MIs.size().

The compile-time regressions from the last commit were caused by the ARM target
including a non-const variable (zero_reg) in the table and therefore generating
an initializer for it. That variable is now const.

Reviewers: ab, t.p.northover, qcolombet, rovka, aditya_nandakumar

Reviewed By: rovka

Subscribers: kristof.beyls, igorb, llvm-commits

Differential Revision: https://reviews.llvm.org/D35681

llvm-svn: 309264

8e82af2b

[CodeGen][ARM] ARM runtime helper functions are not always soft-fp · 32e26753
Peter Smith authored Jul 27, 2017
```
Re-commit r309257 with less precise register checks in arm-float-helpers.c
test.

llvm-svn: 309263
```
32e26753
[X86] Adding test cases for LEA factorization (PR32755 / D35014) · 804cbd61
Simon Pilgrim authored Jul 27, 2017
```
Differential Revision: https://reviews.llvm.org/D35886

llvm-svn: 309262
```
804cbd61

[X86] Tidyup MaskedLoad/Store mask creation. NFCI. · afc1ac27

Simon Pilgrim authored Jul 27, 2017

Assign all concat elements to zero and then just replace the first element, instead of setting them all to null and copying everything in.

llvm-svn: 309261

afc1ac27

[TTI] fixing a bug in the isLegalMaskedScatter API · cef53dcb

Mohammed Agabaria authored Jul 27, 2017

isLegalMaskedScatter called the Gather version which is a bug.
use test case is provided within the patch of AVX2 gathers at: https://reviews.llvm.org/D35772

Differential Revision: https://reviews.llvm.org/D35786

llvm-svn: 309260

cef53dcb

[CodeGen][ARM] Revert r309257 · c03956cf

Peter Smith authored Jul 27, 2017

The test arm-float-helpers.c appears to be failing on some builders and
needs some work to make it more robust.

llvm-svn: 309259

c03956cf

Revert r309252 "[ELF] - Fix missing relocation when linking executable with... · 13f7dcdb

George Rimar authored Jul 27, 2017

Revert r309252 "[ELF] - Fix missing relocation when linking executable with --unresolved-symbols=ignore-all"

It broke bot:
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/4231

llvm-svn: 309258

13f7dcdb

[CodeGen][ARM] ARM runtime helper functions are not always soft-fp · 8459922d

Peter Smith authored Jul 27, 2017

The ARM Runtime ABI document (IHI0043) defines the AEABI floating point
helper functions in 4.1.2 The floating-point helper functions. These
functions always use the base PCS (soft-fp). However helper functions
defined outside of this document such as the complex-number multiply and
divide helpers are not covered by this requirement and should use
hard-float PCS if the target is hard-float as both compiler-rt and libgcc
for a hard-float sysroot implement these functions with a hard-float PCS.

All of the floating point helper functions that are explicitly soft float
are expanded in the llvm ARM backend. This change makes clang not force the
BuiltinCC to AAPCS for AAPCS_VFP. With this change the ARM compiler-rt
tests involving _Complex pass with both hard-fp and soft-fp targets.

Differential Revision: https://reviews.llvm.org/D35538

llvm-svn: 309257

8459922d

[PowerPC] Pass CPU to assembler with -no-integrated-as · f88f81c4

Nemanja Ivanovic authored Jul 27, 2017

This just adds the CPU to a list of commands passed to GAS when not using the
integrated assembler.

Differential Revision: https://reviews.llvm.org/D33820

llvm-svn: 309256

f88f81c4

[PowerPC] enable optimizeCompareInstr for branch with static branch hint · 967dc58a

Hiroshi Inoue authored Jul 27, 2017

In optimizeCompareInstr, a compare instruction is eliminated by using a record form instruction if possible.
If the branch instruction that uses the result of the compare has a static branch hint, the optimization does not happen.
This patch makes this optimization happen regardless of the branch hint by splitting branch hint and branch condition before checking the predicate to identify the possible optimizations.

Differential Revision: https://reviews.llvm.org/D35801

llvm-svn: 309255

967dc58a

[ELD] - Sorted in ASCIIbetical order. NFC. · 81467738
George Rimar authored Jul 27, 2017
```
llvm-svn: 309254
```
81467738

[ELF] - Store PhdrEntry values by pointers instead of storing by value. · aa354187

George Rimar authored Jul 27, 2017

That is slightly more convinent as allows to store pointer on
program header entry in a more safe way.
 
Change was used in 2 patches currently on review.

Differential revision: https://reviews.llvm.org/D35832

llvm-svn: 309253

aa354187

[ELF] - Fix missing relocation when linking executable with --unresolved-symbols=ignore-all · 678188d4

George Rimar authored Jul 27, 2017

This is PR32112. Previously when we linked executable with 
--unresolved-symbols=ignore-all and undefined symbols, like:

_start:
callq und@PLT

we did not create relocations, though it looks in that case
we should delegate handling of such symbols to runtime linker,
hence should emit them. Patch fixes that.

Differential revision: https://reviews.llvm.org/D35724

llvm-svn: 309252

678188d4

Revert "Reland "[LLVM][llvm-objcopy] Added basic plumbing to get things started"" · 88ac9a8c
Petr Hosek authored Jul 27, 2017
```
This change is failing tests on Windows bots due to permissions.

This reverts commit r309249.

llvm-svn: 309251
```
88ac9a8c
[LLDB][MIPS] Fix emulation of Instruction for MIPS64R6 target. · d055b8f8
Nitesh Jain authored Jul 27, 2017
```
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
llvm-svn: 309250
```
d055b8f8

Reland "[LLVM][llvm-objcopy] Added basic plumbing to get things started" · 27bcf6a6

Petr Hosek authored Jul 27, 2017

As discussed on llvm-dev I've implemented the first basic steps towards
llvm-objcopy/llvm-objtool (name pending).

This change adds the ability to copy (without modification) 64-bit
little endian ELF executables that have SHT_PROGBITS, SHT_NOBITS,
SHT_NULL and SHT_STRTAB sections.

Patch by Jake Ehrlich

Differential Revision: https://reviews.llvm.org/D33964

llvm-svn: 309249

27bcf6a6

[X86] Improve the unknown stepping support for Intel CPUs in getHostCPUName · 4eda7561

Craig Topper authored Jul 27, 2017

This patch improves our guessing of unknown Intel CPUs to support Goldmont and skylake-avx512.

Differential Revision: https://reviews.llvm.org/D35161

llvm-svn: 309246

4eda7561

[Coverage] NFC: Simplify sanity checks with a SpellingRange utility · d7369648
Vedant Kumar authored Jul 27, 2017
```
This should simplify D35925.

llvm-svn: 309245
```
d7369648
[Coverage] NFC: Save a pair of calls to get{Start,End} · 7838696e
Vedant Kumar authored Jul 27, 2017
```
llvm-svn: 309244
```
7838696e
[GISel]: Missed passing in a parameter to addUsesFromArgs · 69a9971a
Aditya Nandakumar authored Jul 27, 2017
```
llvm-svn: 309243
```
69a9971a

Remove check for i686. · 11dcf62c

Eric Beckmann authored Jul 27, 2017

libxml2 is supported for 32 bit, so our build system should be checking
the target rather than native os when choosing shared libs.

llvm-svn: 309242

11dcf62c

Re-enable libxml2 tests. · f7e84c3f
Eric Beckmann authored Jul 27, 2017
```
llvm-svn: 309241
```
f7e84c3f
[DWARF] Minor code style modification, no functionality change. · 73e1796d
Spyridoula Gravani authored Jul 27, 2017
```
llvm-svn: 309240
```
73e1796d

Add {Obj,Import,Bitcode}File::Instances to COFF input files. · acd632d3

Rui Ueyama authored Jul 27, 2017

We did the same thing for ELF in r309152, and I want to maintain
COFF and ELF as close as possible.

llvm-svn: 309239

acd632d3

Fix the formatting for help on option value types. · a81bd7f1
Jim Ingham authored Jul 27, 2017
```
Patch by Jessica Han <jessicah@juniper.net>

https://reviews.llvm.org/D35525

llvm-svn: 309238
```
a81bd7f1