Skip to content
  1. Feb 12, 2019
  2. Feb 11, 2019
    • Eli Friedman's avatar
      [Sema] Mark GNU compound literal array init as an rvalue. · 88fccbde
      Eli Friedman authored
      Basically the same issue as string init, except it didn't really have
      any visible consequences before I removed the implicit lvalue-to-rvalue
      conversion from CodeGen.
      
      While I'm here, a couple minor drive-by cleanups: IgnoreParens never
      returns a ConstantExpr, and there was a potential crash with string init
      involving a ChooseExpr.
      
      The analyzer test change maybe indicates we could simplify the analyzer
      code a little with this fix?  Apparently a hack was added to support
      lvalues in initializers in r315750, but I'm not really familiar with the
      relevant code.
      
      Fixes regression reported in the kernel build at
      https://bugs.llvm.org/show_bug.cgi?id=40430#c6 .
      
      Differential Revision: https://reviews.llvm.org/D58069
      
      llvm-svn: 353762
      88fccbde
    • Heejin Ahn's avatar
      [WebAssembly] Make thread-related options consistent · 9d5a089b
      Heejin Ahn authored
      Summary:
      There have been three options related to threads and users had to set
      all three of them separately to get the correct compilation results.
      This makes sure the relationship between the options makes sense and
      sets necessary options for users if only part of the necessary options
      are specified. This does:
      
      - Remove `-matomics`; this option alone does not enable anything, so
        removed it to not confuse users.
      - `-mthread-model posix` sets `-target-feature +atomics`
      - `-pthread` sets both `-target-feature +atomics` and
        `-mthread-model posix`
      Also errors out when explicitly given options don't match, such as
      `-pthread` is given with `-mthread-model single`.
      
      Reviewers: dschuff, sbc100, tlively, sunfish
      
      Subscribers: jgravelle-google, jfb, cfe-commits
      
      Tags: #clang
      
      Differential Revision: https://reviews.llvm.org/D57874
      
      llvm-svn: 353761
      9d5a089b
Loading