We had five different BuildId subclasses for five different types
of build-ids. They can simply be merged to a single class.

llvm-svn: 287603

Config->MaxPageSize is what we use for the segment alignment, so that
is the one that we have to use for placing the header.

llvm-svn: 287569

If the linker script has SECTIONS, the address computation is now
always done in LinkerScript::assignAddresses, like for any other
section.

Before fixHeaders would do a tentative computation that
assignAddresses would sometimes override.

This patch also splits the cases where assignAddresses needs to add
the headers to the first PT_LOAD and the address computation. The net
effect is that we no longer create an empty page for no reason in the
included test case, which matches bfd behavior.

llvm-svn: 287565

This should have been moved along with r287554.

llvm-svn: 287564

Differential revision: https://reviews.llvm.org/D26918

llvm-svn: 287554

Differential revision: https://reviews.llvm.org/D26906

llvm-svn: 287549

Differential revision: https://reviews.llvm.org/D26795

llvm-svn: 287547

LLD's error messages contain line numbers, function names or section names.
Currently they are formatter as follows.

  foo.c (32): symbol 'foo' not found
  foo.c (function bar): symbol 'foo' not found
  foo.c (.text+0x1234): symbol 'foo' not found

This patch changes them so that they are consistent with Clang's output.

  foo.c:32: symbol 'foo' not found
  foo.c:(function bar): symbol 'foo' not found
  foo.c:(.text+0x1234): symbol 'foo' not found

Differential Revision: https://reviews.llvm.org/D26901

llvm-svn: 287537

Differential revision: https://reviews.llvm.org/D26852

llvm-svn: 287527

Differential revision: https://reviews.llvm.org/D26854

llvm-svn: 287526

This patch rearranges code a bit to make it easy to explain.

llvm-svn: 287515

llvm-svn: 287514

llvm-svn: 287510

llvm-svn: 287509

Previously, we set (uintptr_t)-1 to InputSectionBase::OutSec to record
that a section has already been set to be assigned to some output section
by linker scripts. Later, we restored nullptr to the pointer to use
the field for the original purpose. That overloading is not very easy to
understand.

This patch adds a bit flag for that purpose, so that we don't need
to piggyback the flag on an unrelated pointer.

llvm-svn: 287508

llvm-svn: 287481

Also this patch uses file-scope functions instead of class member function.

Now that ICF class is not visible from outside, InputSection class
can no longer be "friend" of it. So I removed the friend relation
and just make it expose the features to public.

llvm-svn: 287480

We have a .cpp and a .h for parseDynamicList(). This patch
moves the function to DriverUtil.cpp.

llvm-svn: 287468

llvm-svn: 287467

In order to use forEachGroup in the final loop in ICF::run,
I changed some function parameter types.

llvm-svn: 287466

llvm-svn: 287460

llvm-svn: 287457

llvm-svn: 287456

This patch also changes its return type to simplify callers.

llvm-svn: 287455

We do not have an option taking more than one arguments,
so we can just say "missing argument" instead of "missing argument(s)".

llvm-svn: 287454

llvm-svn: 287452

llvm-svn: 287451

GNU linkers disagree here.
Though both -version and -v are mentioned
in help to print the version information, GNU ld just normally exits,
while gold can continue linking. We are compatible with ld.bfd here.

This fixes PR31057.

Differential revision: https://reviews.llvm.org/D26865

llvm-svn: 287448

llvm-svn: 287446

Filler expressions in linker script "=fillexp" are always handled
as 32-bit integers. Thus the new type is more natural.

llvm-svn: 287445

llvm-svn: 287372

It seems a lot simpler to just sort the sections and let the
relocations do the rest.

llvm-svn: 287365

Differential revision: https://reviews.llvm.org/D26842

llvm-svn: 287346

Differential revision: https://reviews.llvm.org/D26834

llvm-svn: 287326

llvm-svn: 287325

llvm-svn: 287324

llvm-svn: 287323

Differential revision: https://reviews.llvm.org/D26792

llvm-svn: 287322

readVersionDeclaration was to read anonymous version definition and
named version definition. Splitting it into two functions should
improve readability as the two cases are different enough.

I also changed a few helper functions to return values instead of
mutating given references.

llvm-svn: 287319

llvm-svn: 287318