Skip to content
  1. Sep 10, 2008
  2. Sep 09, 2008
    • Daniel Dunbar's avatar
      Change CodeGen to emit calls using (RValue,Type) list: · 41cf9ded
      Daniel Dunbar authored
       - Add CodeGenFunction::EmitAnyExprToTemp
         o Like EmitAnyExpr, but emits aggregates to a temporary location if
           none is available. Seems like this should be simpler (even aside
           from using first class aggregates).
      
       - Killed CodeGenFunction::EmitCallArg (just append the pair)
      
       - Conversion of RValues to actual call arguments is now isolated in
         CodeGenFunction::EmitCall.
      
      llvm-svn: 55970
      41cf9ded
  3. Sep 08, 2008
    • Daniel Dunbar's avatar
      Refactor parameter attribute handling: · 3d7c90b8
      Daniel Dunbar authored
        - Add CGCall.h for dealing with ABI issues related to calls.
        - Add CGFunctionInfo and CGCallInfo for capturing ABI relevant
          information about functions and calls.
        - Isolate LLVM parameter attribute handling inside CGCall.cpp
      
      llvm-svn: 55963
      3d7c90b8
  4. Sep 04, 2008
  5. Aug 30, 2008
    • Daniel Dunbar's avatar
      Add Objective-C property setter support. · 4b8c6db9
      Daniel Dunbar authored
       - Change Obj-C runtime message API, drop the ObjCMessageExpr arg in
         favor of just result type and selector. Necessary so it can be
         reused in situations where we don't want to cons up an
         ObjCMessageExpr.
       - Update aggregate binary assignment to know about special property
         ref lvalues.
       - Add CodeGenFunction::EmitCallArg overload which takes an already
         emitted rvalue.
      
      Add CodeGenFunction::StoreComplexIntoAddr.
      
      Disabled logic in Sema for parsing Objective-C dot-syntax that
      accesses methods. This code does not search in the correct order and
      the AST node has no way of properly representing its results.
      
      Updated StmtDumper to print a bit more information about
      ObjCPropertyRefExprs.
      
      llvm-svn: 55561
      4b8c6db9
    • Daniel Dunbar's avatar
      Refactor handling of calls: · c722b856
      Daniel Dunbar authored
       - Added CodeGenFunction::EmitCall which just takes the callee, return
         type, and a list of (Value*,QualType) pairs.
       - Added CodeGenFunction::EmitCallArg which handles emitting code for
         a call argument and turning it into an appropriate
         (Value*,QualType) pair.
       - Changed Objective-C runtime interface so that the actual emission
         of arguments for message sends is (once again) done in the code to
         emit a message send.
      
      No intended functionality change, this is prep work for better ABI
      support and for Objective-C property setter support.
      
      llvm-svn: 55560
      c722b856
  6. Aug 29, 2008
  7. Aug 25, 2008
  8. Aug 23, 2008
    • Daniel Dunbar's avatar
      Implement Obj-C ivar references to aggregates. · c8317a44
      Daniel Dunbar authored
      Implement Obj-C lvalue message sends (aggregate returns).
      
      Update several places to emit more precise ErrorUnsupported warnings
        for currently unimplemented Obj-C features (main missing chunks are
        property references, Obj-C exception handling, and the for ... in
        syntax).
      
      llvm-svn: 55234
      c8317a44
    • Daniel Dunbar's avatar
      NeXT: Fix message sends which return structures. · 97ff50dd
      Daniel Dunbar authored
       - Simplify the sending code a bit.
      
      llvm-svn: 55232
      97ff50dd
    • Daniel Dunbar's avatar
      Trim CGObjCRuntime::GenerateMessageSend[Super] · 97db84ce
      Daniel Dunbar authored
       - Returns an RValue.
       - Reduced to only taking the CodeGenFunction, Expr, and Receiver.
       - Becomes responsible for emitting the arguments.
      
      Add CodeGenFunction::EmitCallExprExt
       - Takes optional extra arguments to insert at the head of the call.
       - This allows the Obj-C runtimes to call into this and isolates the
         argument and call instruction generation code to one place. Upshot
         is that we now pass structures (more) correctly.
      
      Also, fix one aspect of generating methods which take structure
      arguments (for NeXT). This probably needs to be merged with the
      SetFunctionAttributes code in CodeGenModule.cpp
      
      llvm-svn: 55223
      97db84ce
  9. Aug 16, 2008
  10. Aug 14, 2008
    • Daniel Dunbar's avatar
      Add GetAddrOfConstantCString method · c4baa06d
      Daniel Dunbar authored
       - Returns addr of constant for argument + '\0'.
       - I couldn't think of a better name.
       - Move appropriate users of GetAddrOfConstantString to this.
      
      Rename getStringForStringLiteral to GetStringForStringLiteral.
      
      Add GetAddrOfConstantStringFromLiteral
       - This combines GetAddrOfConstantString and
         GetStringForStringLiteral. This method can be, but is not yet, more
         efficient.
      
      Change GetAddrOfConstantString to not add terminating '\0'
       - <rdar://problem/6140956>
      
      llvm-svn: 54768
      c4baa06d
  11. Aug 13, 2008
  12. Aug 11, 2008
    • Daniel Dunbar's avatar
      Change CodeGenModule to only create ObjC runtime for ObjC files · 8d480594
      Daniel Dunbar authored
       - Changed CodeGenModule::getObjCRuntime to return reference.
       - Added CodeGenModule::hasObjCRuntime predicate.
      
      llvm-svn: 54645
      8d480594
    • Daniel Dunbar's avatar
      More #include cleaning · 56fdb6ae
      Daniel Dunbar authored
       - Kill unnecessary #includes in .cpp files. This is an automatic
         sweep so some things removed are actually used, but happen to be
         included by a previous header. I tried to get rid of the obvious
         examples and this was the easiest way to trim the #includes in one
         fell swoop.
       - We now return to regularly scheduled development.
      
      llvm-svn: 54632
      56fdb6ae
    • Daniel Dunbar's avatar
      More #include cleaning · 6e8aa537
      Daniel Dunbar authored
       - Drop {Decl.h,DeclObjC.h,IdentifierTable.h} from Expr.h
       - Moved Sema::getCurMethodDecl() out of line (dependent on
         ObjCMethodDecl via dyn_cast).
      
      llvm-svn: 54629
      6e8aa537
    • Daniel Dunbar's avatar
      More #include cleaning · ad319a73
      Daniel Dunbar authored
       - Remove internal uses of AST.h
      
      llvm-svn: 54628
      ad319a73
  13. Aug 10, 2008
    • Daniel Dunbar's avatar
      Back out r54608 (inline string literals were getting an extra '\0') · 6dfdf8c9
      Daniel Dunbar authored
        temporarily, I assumed GetAddrForConstantString literal was being
        used consistently but it doesn't look like it is.
      
      Factored out a CodeGenModule::getStringForStringLiteral which handles
        extracting a std::string for the bytes of a StringLiteral, padded to
        match the type.
      
      Update EmitLValue to use getStringForStringLiteral, this was
        previously not padding strings correctly. Good thing we only emit
        strings in 4 different places!
      
      llvm-svn: 54621
      6dfdf8c9
    • Chris Lattner's avatar
      rename PreDefinedExpr -> PredefinedExpr · 6307f197
      Chris Lattner authored
      llvm-svn: 54605
      6307f197
  14. Aug 06, 2008
    • Daniel Dunbar's avatar
      Fix bitfield accesses which straddle the boundary of the underlying · ead7c912
      Daniel Dunbar authored
      type.
      
       - This generates somewhat less optimal code than before but this is
         not hard to rectify once stable (at the cost of slightly more
         complex code).
      
       - This currently always uses little-endian ordering of the bitfield. 
      
       - This breaks the CodeGen/bitfield.c test because it was grepping for
         hard-coded assembly instructions. Will fix once a better test case
         is constructed (hard to do without execution).
      
       - This fixes SingleSource/UnitTests/2006-01-23-InitializedBitField.c
         and Regression/C/PR1386.c from the test suite.
      
       - <rdar://problem/6085090>, <rdar://problem/6094169>
      
      llvm-svn: 54395
      ead7c912
  15. Aug 04, 2008
    • Chris Lattner's avatar
      · 7adf0760
      Chris Lattner authored
      Finally fix PR2189.  This makes a fairly invasive but important change to
      move getAsArrayType into ASTContext instead of being a method on type.
      This is required because getAsArrayType(const AT), where AT is a typedef
      for "int[10]" needs to return ArrayType(const int, 10).
      
      Fixing this greatly simplifies getArrayDecayedType, which is a good sign.
      
      llvm-svn: 54317
      7adf0760
  16. Jul 31, 2008
  17. Jul 30, 2008
    • Daniel Dunbar's avatar
      Rework codegen emission of globals · 9c426524
      Daniel Dunbar authored
       - No (intended) functionality change.
      
       - Primary purpose is to clearly separate (lazy) construction of
         globals that are a forward declaration or tentative definition from
         those that are the final definition.
      
       - Lazy construction is now encapsulated in
         GetAddrOf{Function,GlobalVar} while final definitions are
         constructed in EmitGlobal{Function,Var}Definition.
       
       - External interface for dealing with globals is now limited to
         EmitGlobal and GetAddrOf{Function,GlobalVar}.
      
       - Also updated helper functions dealing with statics, annotations,
         and ctors to be private.
      
      llvm-svn: 54179
      9c426524
  18. Jul 27, 2008
  19. Jun 17, 2008
    • Chris Lattner's avatar
      Change self/_cmd to be instances of ImplicitParamDecl instead of ParmVarDecl. · 5696e7ba
      Chris Lattner authored
      Patch by David Chisnall!
      
      llvm-svn: 52422
      5696e7ba
    • Ted Kremenek's avatar
      This patch is motivated by numerous strict-aliasing warnings when compiling · 08e17118
      Ted Kremenek authored
      clang as a Release build.
      
      The big change is that all AST nodes (subclasses of Stmt) whose children are
      Expr* store their children as Stmt* or arrays of Stmt*. This is to remove
      strict-aliasing warnings when using StmtIterator. None of the interfaces of any
      of the classes have changed (except those with arg_iterators, see below), as the
      accessor methods introduce the needed casts (via cast<>). While this extra
      casting may seem cumbersome, it actually adds some important sanity checks
      throughout the codebase, as clients using StmtIterator can potentially overwrite
      children that are expected to be Expr* with Stmt* (that aren't Expr*). The casts
      provide extra sanity checks that are operational in debug builds to catch
      invariant violations such as these.
      
      For classes that have arg_iterators (e.g., CallExpr), the definition of
      arg_iterator has been replaced. Instead of it being Expr**, it is an actual
      class (called ExprIterator) that wraps a Stmt**, and provides the necessary
      operators for iteration. The nice thing about this class is that it also uses
      cast<> to type-checking, which introduces extra sanity checks throughout the
      codebase that are useful for debugging.
      
      A few of the CodeGen functions that use arg_iterator (especially from
      OverloadExpr) have been modified to take begin and end iterators instead of a
      base Expr** and the number of arguments. This matches more with the abstraction
      of iteration. This still needs to be cleaned up a little bit, as clients expect
      that ExprIterator is a RandomAccessIterator (which we may or may not wish to
      allow for efficiency of representation).
      
      This is a fairly large patch. It passes the tests (except CodeGen/bitfield.c,
      which was already broken) on both a Debug and Release build, but it should
      obviously be reviewed.
      
      llvm-svn: 52378
      08e17118
  20. Jun 14, 2008
  21. Jun 01, 2008
    • Eli Friedman's avatar
      First cut at setting attributes for functions and calls; this puts us · f6b091f7
      Eli Friedman authored
      much closer to passing the gcc struct layout tests.
      
      It might be possible to refactor this a bit, but I'm not sure there's 
      actually enough common code for that to be useful.
      
      To get the calling convention completely correct, a bit of 
      platform-specific code is necessary even for x86-Linux. On x86-Linux, the
      alignment of function parameters is extremely strange; as far as I can tell,
      it's always 4 except for SSE vectors or structs containing SSE vectors.  I'm 
      continuing to investigate this.
      
      llvm-svn: 51839
      f6b091f7
    • Eli Friedman's avatar
      Minor cleanup to use the ConvertTypeForMem helper. · 149a57f7
      Eli Friedman authored
      llvm-svn: 51837
      149a57f7
  22. May 29, 2008
  23. May 23, 2008
    • Dan Gohman's avatar
      Change uses of llvm::Type::isFirstClassType to use the new · 5d30975e
      Dan Gohman authored
      llvm::Type::isSingleValueType. Currently these two functions have
      the same behavior, but soon isFirstClassType will return true for
      struct and array types.
      
      Clang may some day want to use of isFirstClassType for some of
      these some day as an optimization, but it'll require some
      consideration.
      
      llvm-svn: 51446
      5d30975e
  24. May 22, 2008
    • Dan Gohman's avatar
      Move getAccessedFieldNo out of lib/AST/Expr.cpp into · 75d69da5
      Dan Gohman authored
      lib/CodeGen/CGExpr.cpp and to change include/clang/AST/Attr.h to
      use its own enum for visibility types instead of using
      llvm::GlobalValue::VisibilityTypes. These changes eliminate
      dependencies in the AST library on LLVM's VMCore library.
      
      llvm-svn: 51398
      75d69da5
  25. May 21, 2008
  26. May 19, 2008
  27. May 17, 2008
    • Eli Friedman's avatar
      Fix support for _Bool bitfields. The issue is that the bitfield width · f2442dcc
      Eli Friedman authored
      used for _Bool is not the same as the primitive width (which for _Bool 
      is 1 bit).  The load and store changes add some casts to make the 
      types consistent.  The EmitLValue changes make sure that the pointer is 
      of an appropriate type for loading the bitfield.
      
      This isn't perfect, but it's an improvement, and getting everything 
      right depends on actually laying out structs in an ABI-compliant way.
      
      llvm-svn: 51224
      f2442dcc
  28. May 14, 2008
Loading