Skip to content
  1. Jul 11, 2013
    • Hal Finkel's avatar
      Initialize AsmPrinter::MF in the constructor · 6161b940
      Hal Finkel authored
      MF is normally initialized in AsmPrinter::SetupMachineFunction, but if the file
      contains only globals (no functions), then we need this to be initialized
      because, when encountering an error, lowerConstant() references it.
      
      This should fix the non-deterministic failures of
      test/CodeGen/X86/nonconst-static-iv.ll, etc.
      
      llvm-svn: 186068
      6161b940
    • Hal Finkel's avatar
      RegScavenger should not exclude undef uses · 743b1940
      Hal Finkel authored
      When computing currently-live registers, the register scavenger excludes undef
      uses. As a result, undef uses are ignored when computing the restore points of
      registers spilled into the emergency slots. While the register scavenger
      normally excludes from consideration, when scavenging, registers used by the
      current instruction, we need to not exclude undef uses. Otherwise, we might end
      up requiring more emergency spill slots than we have (in the case where the
      undef use *is* the currently-spilled register).
      
      Another bug found by llvm-stress.
      
      llvm-svn: 186067
      743b1940
    • Craig Topper's avatar
      Fix indentation. No functional change. · 37039640
      Craig Topper authored
      llvm-svn: 186065
      37039640
    • Nadav Rotem's avatar
      Fix a warning. · 08efb262
      Nadav Rotem authored
      llvm-svn: 186064
      08efb262
    • Nadav Rotem's avatar
      SLPVectorizer: refactor the code that places extracts. Place the code that... · b8dd66f6
      Nadav Rotem authored
      SLPVectorizer: refactor the code that places extracts. Place the code that decides where to put extracts in the build-tree phase. This allows us to take the cost of the extracts into account.
      
      llvm-svn: 186058
      b8dd66f6
    • Michael Gottesman's avatar
      Teach TailRecursionElimination to handle certain cases of nocapture escaping allocas. · b40db26e
      Michael Gottesman authored
      Without the changes introduced into this patch, if TRE saw any allocas at all,
      TRE would not perform TRE *or* mark callsites with the tail marker.
      
      Because TRE runs after mem2reg, this inadequacy is not a death sentence. But
      given a callsite A without escaping alloca argument, A may not be able to have
      the tail marker placed on it due to a separate callsite B having a write-back
      parameter passed in via an argument with the nocapture attribute.
      
      Assume that B is the only other callsite besides A and B only has nocapture
      escaping alloca arguments (*NOTE* B may have other arguments that are not passed
      allocas). In this case not marking A with the tail marker is unnecessarily
      conservative since:
      
        1. By assumption A has no escaping alloca arguments itself so it can not
           access the caller's stack via its arguments.
      
        2. Since all of B's escaping alloca arguments are passed as parameters with
           the nocapture attribute, we know that B does not stash said escaping
           allocas in a manner that outlives B itself and thus could be accessed
           indirectly by A.
      
      With the changes introduced by this patch:
      
        1. If we see any escaping allocas passed as a capturing argument, we do
           nothing and bail early.
      
        2. If we do not see any escaping allocas passed as captured arguments but we
           do see escaping allocas passed as nocapture arguments:
      
             i. We do not perform TRE to avoid PR962 since the code generator produces
                significantly worse code for the dynamic allocas that would be created
                by the TRE algorithm.
      
             ii. If we do not return twice, mark call sites without escaping allocas
                 with the tail marker. *NOTE* This excludes functions with escaping
                 nocapture allocas.
      
        3. If we do not see any escaping allocas at all (whether captured or not):
      
             i. If we do not have usage of setjmp, mark all callsites with the tail
                marker.
      
             ii. If there are no dynamic/variable sized allocas in the function,
                 attempt to perform TRE on all callsites in the function.
      
      Based off of a patch by Nick Lewycky.
      
      rdar://14324281.
      
      llvm-svn: 186057
      b40db26e
    • Hal Finkel's avatar
      Don't assert if we can't constant fold extract/insertvalue · b31366da
      Hal Finkel authored
      A non-constant-foldable static initializer expression containing insertvalue or
      extractvalue had been causing an assert:
      
        Constants.cpp:1971: Assertion `FC && "ExtractValue constant expr couldn't be
                                       folded!"' failed.
      
      Now we report a more-sensible "Unsupported expression in static initializer"
      error instead.
      
      Fixes PR15417.
      
      llvm-svn: 186044
      b31366da
    • Rafael Espindola's avatar
      Find the symbol table on archives created on OS X. · 55509920
      Rafael Espindola authored
      llvm-svn: 186041
      55509920
  2. Jul 10, 2013
  3. Jul 09, 2013
    • Adrian Prantl's avatar
      Typo. · 19942885
      Adrian Prantl authored
      llvm-svn: 185971
      19942885
    • Nadav Rotem's avatar
      Fix PR16571, which is a bug in the code that checks that all of the types in... · d7b574e5
      Nadav Rotem authored
      Fix PR16571, which is a bug in the code that checks that all of the types in the bundle are uniform.
      
      llvm-svn: 185970
      d7b574e5
    • Adrian Prantl's avatar
      Reapply an improved version of r180816/180817. · 418d1d1e
      Adrian Prantl authored
      Change the informal convention of DBG_VALUE machine instructions so that
      we can express a register-indirect address with an offset of 0.
      The old convention was that a DBG_VALUE is a register-indirect value if
      the offset (operand 1) is nonzero. The new convention is that a DBG_VALUE
      is register-indirect if the first operand is a register and the second
      operand is an immediate. For plain register values the combination reg,
      reg is used. MachineInstrBuilder::BuildMI knows how to build the new
      DBG_VALUES.
      
      rdar://problem/13658587
      
      llvm-svn: 185966
      418d1d1e
    • Hal Finkel's avatar
      WidenVecRes_BUILD_VECTOR must use the first operand's type · e4dd5c29
      Hal Finkel authored
      Because integer BUILD_VECTOR operands may have a larger type than the result's
      vector element type, and all operands must have the same type, when widening a
      BUILD_VECTOR node by adding UNDEFs, we cannot use the vector element type, but
      rather must use the type of the existing operands.
      
      Another bug found by llvm-stress.
      
      llvm-svn: 185960
      e4dd5c29
Loading