There might be other, similar bugs lurking there.

llvm-svn: 59974

llvm-svn: 59973

One design problem that is emerging is the signed-ness problem during static
analysis. Many unsigned value have to be converted into signed value because
it partipates in operations with signed values. 

On the other hand, we cannot blindly make all values occuring in static analysis
signed, because we do have cases where unsignedness is required, for example,
integer overflow detection.

llvm-svn: 59957

llvm-svn: 59956

llvm-svn: 59951

instead of converting them to strings first.  This also fixes a
bunch of minor inconsistencies in the diagnostics emitted by clang
and adds a bunch of FIXME's to DiagnosticKinds.def.

llvm-svn: 59948

uses of getName() with uses of getDeclName().  This upgrades a bunch of
diags to take DeclNames instead of std::strings.

This also tweaks a couple of diagnostics to be cleaner and changes
CheckInitializerTypes/PerformInitializationByConstructor to pass
around DeclarationNames instead of std::strings.

llvm-svn: 59947

llvm-svn: 59946

llvm-svn: 59943

llvm-svn: 59939

llvm-svn: 59938

NamedDecl::getNameAsString() to make it more explicit.

llvm-svn: 59937

assert if the name is not an identifier.  Update callers to do the right
thing and avoid this method in unsafe cases.  This also fixes an objc
warning that was missing a space, and migrates a couple more to taking
IdentifierInfo and QualTypes instead of std::strings.

llvm-svn: 59936

llvm-svn: 59935

a new NamedDecl::getAsString() method.

Change uses of Selector::getName() to just pass in a Selector 
where possible (e.g. to diagnostics) instead of going through
an std::string.

This also adds new formatters for objcinstance and objcclass
as described in the dox.

llvm-svn: 59933

llvm-svn: 59932

llvm-svn: 59930

llvm-svn: 59923

llvm-svn: 59922

llvm-svn: 59921

"previously defined here" diagnostics all notes.

llvm-svn: 59920

"definitions", not declarations.  Point out the location of the 
original definition.

llvm-svn: 59919

Also, point out where the previous decl was.  This unxfails two tests.

llvm-svn: 59918

with implicit quotes around them.  This has a bunch of follow-on 
effects and requires tweaking to a whole lot of code.  This causes
a regression in two tests (xfailed) by causing it to emit things like:

  Line 10: duplicate interface declaration for category 'MyClass1' ('Category1')

instead of:

  Line 10: duplicate interface declaration for category 'MyClass1(Category1)'

I will fix this in a follow-up commit.

As part of this, I had to start switching stuff to use ->getDeclName() instead
of Decl::getName() for consistency.  This is good, but I was planning to do this
as an independent patch.  There will be several follow-on patches
to clean up some of the mess, but this patch is already too big.

llvm-svn: 59917

without calling getAsString().  This implicitly puts quotes around the
name, so diagnostics need to be tweaked to accommodate this.

llvm-svn: 59916

No functionality change.

llvm-svn: 59908

diags over to use this.  QualTypes implicitly print single quotes around 
them for uniformity and future extension.

Doing this requires a little function pointer dance to prevent libbasic
from depending on libast.

llvm-svn: 59907

llvm-svn: 59903

llvm-svn: 59899

llvm-svn: 59889

llvm-svn: 59887

llvm-svn: 59886

llvm-svn: 59884

llvm-svn: 59881

llvm-svn: 59879

'implicit' property with no 'setter'.

llvm-svn: 59878

Issuing diagnostics when assigning to read-only properties.
This is work in progress.

llvm-svn: 59874

Implement a %plural modifier for complex plural forms in diagnostics. Use it in the overload diagnostics.

llvm-svn: 59871

llvm-svn: 59870

ConcreteInt index for now.

llvm-svn: 59869