Skip to content
  1. Sep 11, 2008
  2. Sep 10, 2008
  3. Sep 09, 2008
  4. Sep 08, 2008
  5. Sep 07, 2008
  6. Sep 06, 2008
  7. Sep 05, 2008
    • Ted Kremenek's avatar
      Add comment back that Argiris pointed out that I mistakenly removed (the... · 6ddf53e4
      Ted Kremenek authored
      Add comment back that Argiris pointed out that I mistakenly removed (the comments below it were stale, so I accidently removed the whole thing).
      
      llvm-svn: 55841
      6ddf53e4
    • Ted Kremenek's avatar
      Change struct forward declarations and definitions to use unique RecordDecls,... · 21475702
      Ted Kremenek authored
      Change struct forward declarations and definitions to use unique RecordDecls, as opposed to creating a single RecordDecl and reusing it.
      
      This change effects both RecordDecls and CXXRecordDecls, but does not effect EnumDecls (yet).
      
      The motivation of this patch is as follows:
      - Capture more source information, necessary for refactoring/rewriting clients.
      
      - Pave the way to resolve ownership issues with RecordDecls with the forthcoming
        addition of DeclGroups.
      
      Current caveats:
      - Until DeclGroups are in place, we will leak RecordDecls not explicitly
        referenced by the AST.  For example:
      
          typedef struct { ... } x;  
      
        The RecordDecl for the struct will be leaked because the TypedefDecl doesn't
        refer to it.  This will be solved with DeclGroups.
        
      - This patch also (temporarily) breaks CodeGen.  More below.
      
      High-level changes:
      - As before, TagType still refers to a TagDecl, but it doesn't own it.  When
        a struct/union/class is first referenced, a RecordType and RecordDecl are
        created for it, and the RecordType refers to that RecordDecl.  Later, if
        a new RecordDecl is created, the pointer to a RecordDecl in RecordType is
        updated to point to the RecordDecl that defines the struct/union/class.
      
      - TagDecl and RecordDecl now how a method 'getDefinition()' to return the
        TagDecl*/RecordDecl* that refers to the TagDecl* that defines a particular
        enum/struct/class/union. This is useful from going from a RecordDecl* that
        defines a forward declaration to the RecordDecl* that provides the actual
        definition. Note that this also works for EnumDecls, except that in this case
        there is no distinction between forward declarations and definitions (yet).
      
      - Clients should no longer assume that 'isDefinition()' returns true from a
        RecordDecl if the corresponding struct/union/class has been defined.
        isDefinition() only returns true if a particular RecordDecl is the defining
        Decl. Use 'getDefinition()' instead to determine if a struct has been defined.
      
      - The main changes to Sema happen in ActOnTag. To make the changes more
        incremental, I split off the processing of enums and structs et al into two
        code paths. Enums use the original code path (which is in ActOnTag) and
        structs use the ActOnTagStruct. Eventually the two code paths will be merged,
        but the idea was to preserve the original logic both for comparison and not to
        change the logic for both enums and structs all at once.
      
      - There is NO CHAINING of RecordDecls for the same RecordType. All RecordDecls
        that correspond to the same type simply have a pointer to that type. If we
        need to figure out what are all the RecordDecls for a given type we can build
        a backmap.
      
      - The diff in CXXRecordDecl.[cpp,h] is actually very small; it just mimics the
        changes to RecordDecl. For some reason 'svn' marks the entire file as changed.
      
      Why is CodeGen broken:
      - Codegen assumes that there is an equivalence between RecordDecl* and
        RecordType*. This was true before because we only created one RecordDecl* for
        a given RecordType*, but it is no longer true. I believe this shouldn't be too
        hard to change, but the patch was big enough as it is.
        
      I have tested this patch on both the clang test suite, and by running the static analyzer over Postgresql and a large Apple-internal project (mix of Objective-C and C).  
      
      llvm-svn: 55839
      21475702
    • Ted Kremenek's avatar
      Remove stale comments. · cb363253
      Ted Kremenek authored
      llvm-svn: 55822
      cb363253
    • Ted Kremenek's avatar
      Remove "NextDecl" from RecordDecl. This change touches many files that where... · 47923c7e
      Ted Kremenek authored
      Remove "NextDecl" from RecordDecl.  This change touches many files that where RecordDecl or CXXRecordDecl was constructed, always with an argument of 'NULL' for the previous declaration.
      
      The motivation behind this change is that chaining the RecordDecls is simply unnecessary.  Once we create multiple RecordDecls for the same struct/union/class, clients that care about all the declarations of the same struct can build a back map by seeing which Decls refer to the same RecordType.
      
      llvm-svn: 55821
      47923c7e
  8. Sep 04, 2008
  9. Sep 03, 2008
  10. Sep 02, 2008
  11. Sep 01, 2008
  12. Aug 30, 2008
    • Daniel Dunbar's avatar
      Add Objective-C property setter support. · 4b8c6db9
      Daniel Dunbar authored
       - Change Obj-C runtime message API, drop the ObjCMessageExpr arg in
         favor of just result type and selector. Necessary so it can be
         reused in situations where we don't want to cons up an
         ObjCMessageExpr.
       - Update aggregate binary assignment to know about special property
         ref lvalues.
       - Add CodeGenFunction::EmitCallArg overload which takes an already
         emitted rvalue.
      
      Add CodeGenFunction::StoreComplexIntoAddr.
      
      Disabled logic in Sema for parsing Objective-C dot-syntax that
      accesses methods. This code does not search in the correct order and
      the AST node has no way of properly representing its results.
      
      Updated StmtDumper to print a bit more information about
      ObjCPropertyRefExprs.
      
      llvm-svn: 55561
      4b8c6db9
  13. Aug 29, 2008
  14. Aug 27, 2008
    • Steve Naroff's avatar
      First wave of changes to support "blocks" (an extension to C). · ec33ed9c
      Steve Naroff authored
      This commit adds the declaration syntax (and associated type).
      
      llvm-svn: 55417
      ec33ed9c
    • Daniel Dunbar's avatar
      Add synthesized property methods to protocols and categories in Sema. · 4684f373
      Daniel Dunbar authored
       - It is not clear that this is the right approach, but this is at
         least consistent with how interfaces are handled.
      
       - This means NeXT now emits the correct metadata for properties in
         protocols.
      
       - This currently introduces a spurious warning involving inherited
         properties in protocols or categories; however, it also fixes some
         situations where we were failing to emit a warning. I will scrub
         this code tomorrow and fix this issue as well as number of other
         missed warnings / error situations that appear to exist.
      
      llvm-svn: 55407
      4684f373
Loading