Skip to content
  1. Apr 09, 2019
  2. Apr 08, 2019
    • Adrian Prantl's avatar
      Fix a stack buffer overflow found by ASAN. · 1a0c0ffa
      Adrian Prantl authored
      llvm::StringRef host_and_port is not guaranteed to be null-terminated.
      Generally, it is not safe at all to convert a StringRef into a char *
      by calling data() on it.
      
      <rdar://problem/49698580>
      
      llvm-svn: 357948
      1a0c0ffa
    • Lang Hames's avatar
      [RuntimeDyld] Decouple RuntimeDyldChecker from RuntimeDyld. · 941f247d
      Lang Hames authored
      This will allow RuntimeDyldChecker (and rtdyld-check tests) to test a new JIT
      linker: JITLink (https://reviews.llvm.org/D58704).
      
      llvm-svn: 357947
      941f247d
    • Louis Dionne's avatar
      [libc++] Remove install_name and compatibility_version on OS X · fecbf591
      Louis Dionne authored
      CMake already specifies those, and we never actually want those to be
      used. In fact, r357811 re-ordered those flags in a way that the
      explicitly-provided install_name was overriding the CMake-provided
      install_name (instead of the other way around). This caused the dylib
      to be considered a system dylib, and hence the explicitly provided rpath
      to be ignored. This, in turn, caused some unit tests to start linking
      against the system libc++.dylib instead of the freshly-built one.
      Specifically, the unit tests that started linking against the system
      dylib are those that didn't specify a DYLD_LIBRARY_PATH, such as
      last_write_time.sh.cpp.
      
      llvm-svn: 357946
      fecbf591
    • Shoaib Meenai's avatar
      [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping · 867131a9
      Shoaib Meenai authored
      The new value is taken from <mach/machine.h> in the MacOSX10.14 SDK from
      Xcode 10.1. Update llvm-objdump and llvm-readobj accordingly.
      
      Differential Revision: https://reviews.llvm.org/D58636
      
      llvm-svn: 357945
      867131a9
    • Eric Fiselier's avatar
      Make reads and writes of the guard variable atomic. · 62c2b5ac
      Eric Fiselier authored
      The read of the guard variable by the caller is atomic,
      and doesn't happen under a mutex.
      
      Our internal reads and writes were non-atomic, because they happened
      under a mutex.
      
      The writes should always be atomic since they can be observed outside
      of the lock.
      
      Making the reads atomic is not strictly necessary under the current
      global mutex approach, but will be under implementations that use a
      futex (which I plan to land shortly). However, they should add little
      additional cost.
      
      llvm-svn: 357944
      62c2b5ac
    • Sanjay Patel's avatar
      [InstCombine] peek through fdiv to find a squared sqrt · 773e04c8
      Sanjay Patel authored
      A more general canonicalization between fdiv and fmul would not
      handle this case because that would have to be limited by uses
      to prevent 2 values from becoming 3 values:
      (x/y) * (x/y) --> (x*x) / (y*y)
      
      (But we probably should still have that limited -- but more general --
      canonicalization independently of this change.)
      
      llvm-svn: 357943
      773e04c8
    • Simon Pilgrim's avatar
      [TargetLowering] SimplifyDemandedBits - use DemandedElts in bitcast handling · 9f74df7d
      Simon Pilgrim authored
      Be more selective in the SimplifyDemandedBits -> SimplifyDemandedVectorElts bitcast call based on the demanded elts.
      
      llvm-svn: 357942
      9f74df7d
    • Chandler Carruth's avatar
      Move the builtin headers to use the new license file header. · 4cf5743b
      Chandler Carruth authored
      Summary:
      These all had somewhat custom file headers with different text from the
      ones I searched for previously, and so I missed them. Thanks to Hal and
      Kristina and others who prompted me to fix this, and sorry it took so
      long.
      
      Reviewers: hfinkel
      
      Subscribers: mcrosier, javed.absar, cfe-commits
      
      Tags: #clang
      
      Differential Revision: https://reviews.llvm.org/D60406
      
      llvm-svn: 357941
      4cf5743b
    • Shafik Yaghmour's avatar
      [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using... · d4263123
      Shafik Yaghmour authored
      [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName
      
      Summary:
      https://reviews.llvm.org/D51633 added error handling to the ASTNodeImporter::VisitEnumDecl(...) for the conflicting names case. This could lead to erroneous return of an error in that case since we should have been using SearchName. Name may be empty in the case where we find the name via getTypedefNameForAnonDecl(...).
      
      Differential Revision: https://reviews.llvm.org/D59665
      
      llvm-svn: 357940
      d4263123
    • Sanjay Patel's avatar
      [InstCombine] add extra-use tests for fmul+sqrt; NFC · bf1417d7
      Sanjay Patel authored
      llvm-svn: 357939
      bf1417d7
    • Nikita Popov's avatar
      [InstCombine] Add more tests for signed saturing math overflow; NFC · 15abd74d
      Nikita Popov authored
      Overflow conditions for sadd.sat and ssub.sat which can be determined
      based on constant ranges, but not necessarily known bits.
      
      llvm-svn: 357938
      15abd74d
    • David Goldman's avatar
      Clean up ObjCPropertyDecl printing · fa8185c5
      David Goldman authored
      Summary:
      - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`.
      - Change priority of attributes (see code/comments inline).
      - Support for printing weak and unsafe_unretained attributes.
      
      Subscribers: arphaman, jfb, cfe-commits
      
      Tags: #clang
      
      Differential Revision: https://reviews.llvm.org/D57965
      
      llvm-svn: 357937
      fa8185c5
    • Nico Weber's avatar
      llvm-undname: Fix more crashes and asserts on invalid inputs · 63b97d2a
      Nico Weber authored
      For functions whose callers don't check that enough input is present,
      add checks at the start of the function that enough input is there and
      set Error otherwise.
      
      For functions that return AST objects, return nullptr instead of
      incomplete AST objects with nullptr fields if an error occurred during
      the function.
      
      Introduce a new function demangleDeclarator() for the sequence
      demangleFullyQualifiedSymbolName(); demangleEncodedSymbol() and
      use it in the two places that had this sequence. Let this new function
      check that ConversionOperatorIdentifiers have a valid TargetType.
      
      Some of the bad inputs found by oss-fuzz, others by inspection.
      
      Differential Revision: https://reviews.llvm.org/D60354
      
      llvm-svn: 357936
      63b97d2a
    • Craig Topper's avatar
      [X86] Fix a couple lowering functions that called ReplaceAllUsesOfValueWith... · 3a4c2192
      Craig Topper authored
      [X86] Fix a couple lowering functions that called ReplaceAllUsesOfValueWith for the newly created code and then return SDValue(). Use MERGE_VALUES instead.
      
      Returning SDValue() makes the caller think custom lowering was unsuccessful and then it will fall back to trying to expand the original node. This expanded code will end up with no users and end up being pruned later. But it was useless unnecessary work to create it.
      
      Instead return a MERGE_VALUES with all the results so the caller knows something changed. The caller can handle the replacements.
      
      For one of the cases I had to use UNDEF has a dummy value for a result we know is unused. This should get pruned later.
      
      llvm-svn: 357935
      3a4c2192
Loading