Skip to content
  1. Mar 19, 2021
    • Andrew Young's avatar
      [mlir] Support use-def cycles in graph regions during regionDCE · f178c13f
      Andrew Young authored
      When deleting operations in DCE, the algorithm uses a post-order walk of
      the IR to ensure that value uses were erased before value defs. Graph
      regions do not have the same structural invariants as SSA CFG, and this
      post order walk could delete value defs before uses.  This problem is
      guaranteed to occur when there is a cycle in the use-def graph.
      
      This change stops DCE from visiting the operations and blocks in any
      meaningful order.  Instead, we rely on explicitly dropping all uses of a
      value before deleting it.
      
      Reviewed By: mehdi_amini, rriddle
      
      Differential Revision: https://reviews.llvm.org/D98919
      f178c13f
    • Vladislav Vinogradov's avatar
      [mlir] Fix Python bindings tests failure in Debug mode after D98474 · 270a336f
      Vladislav Vinogradov authored
      Add extra `type.isa<FloatType>()` check to  `FloatAttr::get(Type, double)` method.
      Otherwise it tries to call `type.cast<FloatType>()`, which fails with assertion in Debug mode.
      
      The `!type.isa<FloatType>()` case just redirercts the call to `FloatAttr::get(Type, APFloat)`,
      which will perform the actual check and emit appropriate error.
      
      Reviewed By: mehdi_amini
      
      Differential Revision: https://reviews.llvm.org/D98764
      270a336f
    • Rob Suderman's avatar
      [mlir][tosa] Add lowering for tosa.rescale to linalg.generic · 286a9d46
      Rob Suderman authored
      This adds a tosa.apply_scale operation that handles the scaling operation
      common to quantized operatons. This scalar operation is lowered
      in TosaToStandard.
      
      We use a separate ApplyScale factorization as this is a replicable pattern
      within TOSA. ApplyScale can be reused within pool/convolution/mul/matmul
      for their quantized variants.
      
      Tests are added to both tosa-to-standard and tosa-to-linalg-on-tensors
      that verify each pass is correct.
      
      Reviewed By: silvas
      
      Differential Revision: https://reviews.llvm.org/D98753
      286a9d46
  2. Mar 18, 2021
  3. Mar 17, 2021
  4. Mar 16, 2021
    • Eugene Zhulenev's avatar
      [mlir] Add lowering from math::Log1p to LLVM · 74f6138b
      Eugene Zhulenev authored
      [mlir] Add lowering from math::Log1p to LLVM
      
      Reviewed By: cota
      
      Differential Revision: https://reviews.llvm.org/D98662
      74f6138b
    • River Riddle's avatar
      [mlir][PDL] Add support for variadic operands and results in the PDL byte code · 85ab413b
      River Riddle authored
      Supporting ranges in the byte code requires additional complexity, given that a range can't be easily representable as an opaque void *, as is possible with the existing bytecode value types (Attribute, Type, Value, etc.). To enable representing a range with void *, an auxillary storage is used for the actual range itself, with the pointer being passed around in the normal byte code memory. For type ranges, a TypeRange is stored. For value ranges, a ValueRange is stored. The above problem represents a majority of the complexity involved in this revision, the rest is adapting/adding byte code operations to support the changes made to the PDL interpreter in the parent revision.
      
      After this revision, PDL will have initial end-to-end support for variadic operands/results.
      
      Differential Revision: https://reviews.llvm.org/D95723
      85ab413b
    • River Riddle's avatar
      [mlir][PDL] Add support for variadic operands and results in the PDL Interpreter · 3a833a0e
      River Riddle authored
      This revision extends the PDL Interpreter dialect to add support for variadic operands and results, with ranges of these values represented via the recently added !pdl.range type. To support this extension, three new operations have been added that closely match the single variant:
      * pdl_interp.check_types : Compare a range of types with a known range.
      * pdl_interp.create_types : Create a constant range of types.
      * pdl_interp.get_operands : Get a range of operands from an operation.
      * pdl_interp.get_results : Get a range of results from an operation.
      * pdl_interp.switch_types : Switch on a range of types.
      
      This revision handles adding support in the interpreter dialect and the conversion from PDL to PDLInterp. Support for variadic operands and results in the bytecode will be added in a followup revision.
      
      Differential Revision: https://reviews.llvm.org/D95722
      3a833a0e
    • River Riddle's avatar
      [mlir][PDL] Add support for variadic operands and results in PDL · 1eb6994d
      River Riddle authored
      This revision extends the PDL dialect to add support for variadic operands and results, with ranges of these values represented via the recently added !pdl.range type. To support this extension, three new operations have been added that closely match the single variant:
      * pdl.operands : Define a range of input operands.
      * pdl.results : Extract a result group from an operation.
      * pdl.types : Define a handle to a range of types.
      
      Support for these in the pdl interpreter dialect and byte code will be added in followup revisions.
      
      Differential Revision: https://reviews.llvm.org/D95721
      1eb6994d
    • River Riddle's avatar
      [mlir][pdl] Remove CreateNativeOp in favor of a more general ApplyNativeRewriteOp. · 02c4c0d5
      River Riddle authored
      This has a numerous amount of benefits, given the overly clunky nature of CreateNativeOp:
      * Users can now call into arbitrary rewrite functions from inside of PDL, allowing for more natural interleaving of PDL/C++ and enabling for more of the pattern to be in PDL.
      * Removes the need for an additional set of C++ functions/registry/etc. The new ApplyNativeRewriteOp will use the same PDLRewriteFunction as the existing RewriteOp. This reduces the API surface area exposed to users.
      
      This revision also introduces a new PDLResultList class. This class is used to provide results of native rewrite functions back to PDL. We introduce a new class instead of using a SmallVector to simplify the work necessary for variadics, given that ranges will require some changes to the structure of PDLValue.
      
      Differential Revision: https://reviews.llvm.org/D95720
      02c4c0d5
    • River Riddle's avatar
      [mlir][pdl] Restructure how results are represented. · 242762c9
      River Riddle authored
      Up until now, results have been represented as additional results to a pdl.operation. This is fairly clunky, as it mismatches the representation of the rest of the IR constructs(e.g. pdl.operand) and also isn't a viable representation for operations returned by pdl.create_native. This representation also creates much more difficult problems when factoring in support for variadic result groups, optional results, etc. To resolve some of these problems, and simplify adding support for variable length results, this revision extracts the representation for results out of pdl.operation in the form of a new `pdl.result` operation. This operation returns the result of an operation at a given index, e.g.:
      
      ```
      %root = pdl.operation ...
      %result = pdl.result 0 of %root
      ```
      
      Differential Revision: https://reviews.llvm.org/D95719
      242762c9
    • Aart Bik's avatar
      [mlir][amx] reformatted examples · b85d3e27
      Aart Bik authored
      Examples were missing the underscore of the actual ops format.
      
      Reviewed By: ftynse
      
      Differential Revision: https://reviews.llvm.org/D98723
      b85d3e27
    • Aart Bik's avatar
      [mlir][amx] blocked tilezero integration test · b388bbd3
      Aart Bik authored
      This adds a new integration test. However, it also
      adapts to a recent memref.XXX change for existing tests
      
      Reviewed By: ftynse
      
      Differential Revision: https://reviews.llvm.org/D98680
      b388bbd3
Loading