Skip to content
  1. Sep 28, 2016
  2. Sep 27, 2016
    • Adam Nemet's avatar
      [Inliner] Fold the analysis remark into the missed remark · 1142147e
      Adam Nemet authored
      There is really no reason for these to be separate.
      
      The vectorizer started this pretty bad tradition that the text of the
      missed remarks is pretty meaningless, i.e. vectorization failed.  There,
      you have to query analysis to get the full picture.
      
      I think we should just explain the reason for missing the optimization
      in the missed remark when possible.  Analysis remarks should provide
      information that the pass gathers regardless whether the optimization is
      passing or not.
      
      llvm-svn: 282542
      1142147e
    • Michael Zolotukhin's avatar
    • Adam Nemet's avatar
      Adapt to LLVM optimization remark interface change. NFC · 699fc5b1
      Adam Nemet authored
      llvm-svn: 282540
      699fc5b1
    • Adam Nemet's avatar
      Output optimization remarks in YAML · a62b7e1a
      Adam Nemet authored
      (Re-committed after moving the template specialization under the yaml
      namespace.  GCC was complaining about this.)
      
      This allows various presentation of this data using an external tool.
      This was first recommended here[1].
      
      As an example, consider this module:
      
        1 int foo();
        2 int bar();
        3
        4 int baz() {
        5   return foo() + bar();
        6 }
      
      The inliner generates these missed-optimization remarks today (the
      hotness information is pulled from PGO):
      
        remark: /tmp/s.c:5:10: foo will not be inlined into baz (hotness: 30)
        remark: /tmp/s.c:5:18: bar will not be inlined into baz (hotness: 30)
      
      Now with -pass-remarks-output=<yaml-file>, we generate this YAML file:
      
        --- !Missed
        Pass:            inline
        Name:            NotInlined
        DebugLoc:        { File: /tmp/s.c, Line: 5, Column: 10 }
        Function:        baz
        Hotness:         30
        Args:
          - Callee: foo
          - String:  will not be inlined into
          - Caller: baz
        ...
        --- !Missed
        Pass:            inline
        Name:            NotInlined
        DebugLoc:        { File: /tmp/s.c, Line: 5, Column: 18 }
        Function:        baz
        Hotness:         30
        Args:
          - Callee: bar
          - String:  will not be inlined into
          - Caller: baz
        ...
      
      This is a summary of the high-level decisions:
      
      * There is a new streaming interface to emit optimization remarks.
      E.g. for the inliner remark above:
      
         ORE.emit(DiagnosticInfoOptimizationRemarkMissed(
                      DEBUG_TYPE, "NotInlined", &I)
                  << NV("Callee", Callee) << " will not be inlined into "
                  << NV("Caller", CS.getCaller()) << setIsVerbose());
      
      NV stands for named value and allows the YAML client to process a remark
      using its name (NotInlined) and the named arguments (Callee and Caller)
      without parsing the text of the message.
      
      Subsequent patches will update ORE users to use the new streaming API.
      
      * I am using YAML I/O for writing the YAML file.  YAML I/O requires you
      to specify reading and writing at once but reading is highly non-trivial
      for some of the more complex LLVM types.  Since it's not clear that we
      (ever) want to use LLVM to parse this YAML file, the code supports and
      asserts that we're writing only.
      
      On the other hand, I did experiment that the class hierarchy starting at
      DiagnosticInfoOptimizationBase can be mapped back from YAML generated
      here (see D24479).
      
      * The YAML stream is stored in the LLVM context.
      
      * In the example, we can probably further specify the IR value used,
      i.e. print "Function" rather than "Value".
      
      * As before hotness is computed in the analysis pass instead of
      DiganosticInfo.  This avoids the layering problem since BFI is in
      Analysis while DiagnosticInfo is in IR.
      
      [1] https://reviews.llvm.org/D19678#419445
      
      Differential Revision: https://reviews.llvm.org/D24587
      
      llvm-svn: 282539
      a62b7e1a
    • Adam Nemet's avatar
      Sort headers · 37c9e7f3
      Adam Nemet authored
      llvm-svn: 282538
      37c9e7f3
    • Zachary Turner's avatar
      Update FileSpec's interface to use StringRefs. · fe83ad8b
      Zachary Turner authored
      Differential Revision: https://reviews.llvm.org/D24936
      
      llvm-svn: 282537
      fe83ad8b
    • Michal Gorny's avatar
      [cmake] Support overriding remaining HTML doc install directories · c496c502
      Michal Gorny authored
      Support overriding the Doxygen & OCamldoc install directories,
      and provide a more FHS-compliant defaults for both of them. This extends
      r282240 that added this override for Sphinx-built documentation.
      
      LLVM_INSTALL_DOXYGEN_HTML_DIR and LLVM_INSTALL_OCAMLDOC_HTML_DIR are
      added, to control the location where Doxygen-generated and
      OCamldoc-generated HTML docs are installed appropriately. They both
      specify CMake-style install paths, and therefore can either by relative
      to the install prefix or absolute.
      
      The new defaults are subdirectories of share/doc/llvm, and replace
      the previous directories of 'docs/html' and 'docs/ocaml/html' that
      resulted in creating invalid '/usr/docs' that furthermore lacked proper
      namespacing for the LLVM package. The new defaults are consistent with
      the ones used for Sphinx HTML documentation, differing only in the last
      component. Since the 'html' subdirectory is already used for Sphinx
      docs, the 'doxygen-html' and 'ocaml-html' directories are used instead.
      
      Differential Revision: https://reviews.llvm.org/D24935
      
      llvm-svn: 282536
      c496c502
    • Martin Storsjö's avatar
      Fix a typo, depricated -> deprecated · 055a7026
      Martin Storsjö authored
      Differential Revision: https://reviews.llvm.org/D22849
      
      llvm-svn: 282534
      055a7026
    • Matthias Braun's avatar
      Adapt to LLVM EnableStatistics() change. · ec1c5a20
      Matthias Braun authored
      llvm-svn: 282533
      ec1c5a20
    • Matthias Braun's avatar
      Statistic: Bring back printing on exit by default · 5391ffb6
      Matthias Braun authored
      Turns out several external projects relied on llvm printing statistics
      on exit. Let's go back to this behaviour by default and have an optional
      parameter to disable it.
      
      llvm-svn: 282532
      5391ffb6
    • Martin Storsjö's avatar
      [COFF] Add support for IMAGE_REL_ARM_SECREL · 63762b58
      Martin Storsjö authored
      Handle this in the exact same way as IMAGE_REL_AMD64_SECREL
      and IMAGE_REL_I386_SECREL.
      
      Differential revision: https://reviews.llvm.org/D24608
      
      llvm-svn: 282531
      63762b58
    • Saleem Abdulrasool's avatar
      builtins: use thumb-2 if possible on comparesf2 · 81eb5f6a
      Saleem Abdulrasool authored
      This code can be built with thumb-2 like many of the other builtin routines.
      Enable that here as well.
      
      llvm-svn: 282530
      81eb5f6a
    • Dimitar Vlahovski's avatar
      Adding a RegisterContextMinidump_x86_64 converter · 4c31907d
      Dimitar Vlahovski authored
      Summary:
      This is a register context converter from Minidump to Linux reg context.
      This knows the layout of the register context in the Minidump file
      (which is the same as in Windows FYI) and as a result emits a binary data
      buffer that matches the Linux register context binary layout.
      This way we can reuse the existing RegisterContextLinux_x86_64 and
      RegisterContextCorePOSIX_x86_64 classes.
      
      Reviewers: labath, zturner
      
      Subscribers: beanz, mgorny, lldb-commits, amccarth
      
      Differential Revision: https://reviews.llvm.org/D24919
      
      llvm-svn: 282529
      4c31907d
    • Daniel Dunbar's avatar
      [lit] Add instructions to run lit's test suite · 5a751c63
      Daniel Dunbar authored
       - Patch by Brian Gesiak.
       
       - https://reviews.llvm.org/D24968
      
      llvm-svn: 282525
      5a751c63
    • Michal Gorny's avatar
      Revert r282483 - [cmake] Add linker option "-Wl,-z,defs" in standalone build · 0e40bee8
      Michal Gorny authored
      Revert r282483 as it causes build failures due to missing symbols when
      not linking to -lgcc_s (i.e. doing pure LLVM stack build). The patch can
      be reintroduced when the build system is fixed to add all needed
      libraries (libunwind, compiler-rt).
      
      llvm-svn: 282524
      0e40bee8
    • Davide Italiano's avatar
      [llvm-cxxfilt] Use llvm::outs(). Simplify. · c37eb11f
      Davide Italiano authored
      This adds a dependency on Support/. As llvm-cxxfilt will grow
      support for options this will be needed anyway.
      
      llvm-svn: 282523
      c37eb11f
    • Sanjay Patel's avatar
      [x86] use isNullFPConstant(); NFCI · 43ef1ad0
      Sanjay Patel authored
      Also, put the related FP logic functions together to see the similarities. 
      
      llvm-svn: 282522
      43ef1ad0
    • Reid Kleckner's avatar
      [DebugInfo] Add comments to phi dbg.value tracking code, NFC · 6481822e
      Reid Kleckner authored
      LLVM developers might be surprised to learn that there are blocks
      without valid insertion points (catchswitch), so it seems worth calling
      that out explicitly.  Also add a FIXME about what we should really be
      doing if we ever need to make optimized Windows EH code debuggable.
      
      While I'm here, make auto usage more consistent with LLVM standards and
      avoid an unecessary call to insertBefore.
      
      llvm-svn: 282521
      6481822e
    • Krzysztof Parzyszek's avatar
      [RDF] Add "dead" flag to node attributes · 586fc12e
      Krzysztof Parzyszek authored
      llvm-svn: 282520
      586fc12e
    • Krzysztof Parzyszek's avatar
      [RDF] Special treatment of exception handling registers · 1d322207
      Krzysztof Parzyszek authored
      A landing pad can have live-in registers that are defined by the runtime,
      not the program (exception pointer register and exception selector
      register). Make sure to recognize that case and not link these registers
      with any defs in the program.
      Each landing pad will have phi nodes added at the beginning to provide
      definitions of these registers, but the uses of those phi nodes will not
      have any reaching defs.
      
      llvm-svn: 282519
      1d322207
    • Chris Bieneman's avatar
      Improve CMake output of host and target triple · 0775a232
      Chris Bieneman authored
      Summary:
      The previous output was confusing as it would output "Taget triple:
      x86_64-unknown-linux-gnu" even when LLVM_HOST_TRIPLE or
      LLVM_DEFAULT_TARGET_TRIPLE were set on the CMake command line
      
      Patch by: Alex Richardson!
      
      Reviewers: beanz
      
      Subscribers: Eugene.Zelenko
      
      Differential Revision: https://reviews.llvm.org/D17067
      
      llvm-svn: 282516
      0775a232
    • Sanjoy Das's avatar
      [SCEV] Replace a struct with a function; NFC · 237c8454
      Sanjoy Das authored
      We can do this now thanks to C++11 lambdas.
      
      llvm-svn: 282515
      237c8454
    • Sanjoy Das's avatar
      [SCEV] Use find instead of find_as; NFC · a2602141
      Sanjoy Das authored
      We don't need the extra generality here.
      
      llvm-svn: 282514
      a2602141
    • Sanjoy Das's avatar
      [SCEV] Reduce the scope of a struct; NFC · c220ac79
      Sanjoy Das authored
      llvm-svn: 282513
      c220ac79
    • Sanjoy Das's avatar
      [SCEV] Remove custom RAII wrapper; NFC · c46bceb6
      Sanjoy Das authored
      Instead use the pre-existing `scope_exit` class.
      
      llvm-svn: 282512
      c46bceb6
    • Sanjoy Das's avatar
      [SCEV] Make PendingLoopPredicates more frugal; NFCI · db933757
      Sanjoy Das authored
      I don't expect `PendingLoopPredicates` to have very many
      elements (e.g. when -O3'ing the sqlite3 amalgamation,
      `PendingLoopPredicates` has at most 3 elements).  So now we use a
      `SmallPtrSet` for it instead of the more heavyweight `DenseSet`.
      
      llvm-svn: 282511
      db933757
    • Chris Bieneman's avatar
      [CMake] Use if(... IN_LIST ...) instead of list(FIND...) · 44d29908
      Chris Bieneman authored
      NFC. This is just a little code cleanup to make things easier to read and understand.
      
      llvm-svn: 282510
      44d29908
    • Jonathan Peyton's avatar
      Mixed type atomic routines for unsigned integers. · be31337e
      Jonathan Peyton authored
      New routines should be used for atomics like "<int>OP=<float>" when <int> is
      unsigned. Using functions __kmpc_atomic_fixed<bits>_<op>_fp) produces incorrect
      results
      
      Differential Revision: https://reviews.llvm.org/D24756
      
      llvm-svn: 282509
      be31337e
    • Todd Fiala's avatar
      convert TestFatArchives.py over to no-debug-info test · 789ea82f
      Todd Fiala authored
      We only use the .o-style debug info here regardless, so having
      it run all three debuginfo styles was a waste.
      
      This also strips out the custom build function and uses the
      TestBase.build() method.
      
      llvm-svn: 282508
      789ea82f
    • Jonathan Peyton's avatar
      Disable monitor thread creation by default. · b66d1aab
      Jonathan Peyton authored
      This change set disables creation of the monitor thread by default.  The global
      counter maintained by the monitor thread was replaced by logic that uses system
      time directly, and cyclic yielding on Linux target was also removed since there
      was no clear benefit of using it. Turning on KMP_USE_MONITOR variable (=1)
      enables creation of monitor thread again if it is really necessary for some
      reasons.
      
      Differential Revision: https://reviews.llvm.org/D24739
      
      llvm-svn: 282507
      b66d1aab
Loading