- May 28, 2015
-
-
Chandler Carruth authored
This will be used in my next commit to Clang. llvm-svn: 238388
-
Duncan P. N. Exon Smith authored
Should fix the -Werror release build: http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/11113 llvm-svn: 238375
-
Duncan P. N. Exon Smith authored
Change `DIE::addChild()` to return a reference to the just-added node, and update consumers to use it directly. An upcoming commit will abstract away (and eventually change) the underlying storage of `DIE::Children`. llvm-svn: 238372
-
Fiona Glaser authored
llvm-svn: 238371
-
Duncan P. N. Exon Smith authored
Change the `DIE` API to hide the implementation of the list of `DIEValue`s. llvm-svn: 238369
-
Duncan P. N. Exon Smith authored
Remove "the most boring struct ever" (thanks to review by Eric). llvm-svn: 238366
-
Duncan P. N. Exon Smith authored
Stop storing a `DIEAbbrev` in `DIE`, since the data fits neatly inside the `DIEValue` list. Besides being a cleaner data structure (avoiding the parallel arrays), this gives us more freedom to rearrange the `DIEValue` list. This fixes the temporary memory regression from 845 MB up to 879 MB, and drops it further to 829 MB for a net memory decrease of around 1.9% (incremental decrease around 5.7%). (I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`; see r236629 for details.) llvm-svn: 238364
-
Duncan P. N. Exon Smith authored
This reverts commit r238350, effectively reapplying r238349 after fixing (all?) the problems, all somehow related to how I was using `AlignedArrayCharUnion<>` inside `DIEValue`: - MSVC can only handle `sizeof()` on types, not values. Change the assert. - GCC doesn't know the `is_trivially_copyable` type trait. Instead of asserting it, add destructors. - Call placement new even when constructing POD (i.e., the pointers). - Instead of copying the char buffer, copy the casted classes. I've left in a couple of `static_assert`s that I think both MSVC and GCC know how to handle. If the bots disagree with me, I'll remove them. - Check that the constructed type is either standard layout or a pointer. This protects against a programming error: we really want the "small" `DIEValue`s to be small and simple, so don't accidentally change them not to be. - Similarly, check that the size of the buffer is no bigger than a `uint64_t` or a pointer. (I thought checking against `sizeof(uint64_t)` would be good enough, but Chandler suggested that pointers might sometimes be bigger than that in the context of sanitizers.) I've also committed r238359 in the meantime, which introduces a DIEValue.def to simplify dispatching between the various types (thanks to a review comment by David Blaikie). Without that, this commit would be almost unintelligible. Here's the original commit message: -- Change `DIEValue` to be stored/passed/etc. by value, instead of reference. It's now a discriminated union, with a `Val` field storing the actual type. The classes that used to inherit from `DIEValue` no longer do. There are two categories of these: - Small values fit in a single pointer and are stored by value. - Large values require auxiliary storage, and are stored by reference. The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It was relying on `DIEInteger`s being passed around by reference, so I replaced that assumption with a `PatchLocation` type that stores a safe reference to where the `DIEInteger` lives instead. This commit causes a temporary regression in memory usage, since I've left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up drops it lower than the starting point, and I've only recently brought the memory this low anyway, so I'm committing these changes separately to keep them incremental. (I also considered swapping the commits, but the other one first would cause a lot more code churn.) (I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`; see r236629 for details.) -- llvm-svn: 238362
-
- May 27, 2015
-
-
Duncan P. N. Exon Smith authored
Use a .def macro file to iterate through the various subclasses of `DIEValue`. llvm-svn: 238359
-
Rafael Espindola authored
I think this concludes the merge of MCSectionData and MCSection. llvm-svn: 238358
-
Rafael Espindola authored
Both MCStreamer and MCObjectStreamer were maintaining a current section variable and they were slightly out of sync. I don't think this was observable, but was inefficient and error prone. Changing this requires a few cascading changes: * SwitchSection has to call ChangeSection earlier for ChangeSection to see the old section. * With that change, ChangeSection cannot call EmitLabel, since during ChangeSection we are still in the old section. * When the object streamer requires a begin label, just reused the existing generic support for begin labels instead of calling EmitLabel directly. llvm-svn: 238357
-
Lang Hames authored
Previously, relocations of the form 'A - B + C' would fail on i386 when C was non-zero. llvm-svn: 238356
-
Renato Golin authored
Simple change to make arch like "thumbv6" and "armbev6" to return the correct CPU for FreeBSD and NetBSD. llvm-svn: 238353
-
Diego Novillo authored
This fixes a bit I forgot in r238335. In addition to the data record and the counter, we can also move the name of the counter to the comdat for the associated function. I'm also adding an IR test case to check that these three elements are placed in the proper comdat. llvm-svn: 238351
-
Duncan P. N. Exon Smith authored
This reverts commit r238349, since it caused some errors on bots: - std::is_trivially_copyable isn't available until GCC 5.0. - It was complaining about strict aliasing with my use of ArrayCharUnion. llvm-svn: 238350
-
Duncan P. N. Exon Smith authored
Change `DIEValue` to be stored/passed/etc. by value, instead of reference. It's now a discriminated union, with a `Val` field storing the actual type. The classes that used to inherit from `DIEValue` no longer do. There are two categories of these: - Small values fit in a single pointer and are stored by value. - Large values require auxiliary storage, and are stored by reference. The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp. It was relying on `DIEInteger`s being passed around by reference, so I replaced that assumption with a `PatchLocation` type that stores a safe reference to where the `DIEInteger` lives instead. This commit causes a temporary regression in memory usage, since I've left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit. I measured an increase from 845 MB to 879 MB, around 3.9%. The follow-up drops it lower than the starting point, and I've only recently brought the memory this low anyway, so I'm committing these changes separately to keep them incremental. (I also considered swapping the commits, but the other one first would cause a lot more code churn.) (I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`; see r236629 for details.) llvm-svn: 238349
-
Duncan P. N. Exon Smith authored
An upcoming commit will switch to storing `DIEValue`s by value in a `DIE`, so move the `DIE` down below all the subclasses it can. Two subclasses inherit from `DIE`, so drop those down below `DIE`. `DIEValue` will become a discriminated union, which contains an instance of one of the classes that are currently subclasses. "Big" ones, such as those that inherit from `DIE`, will continue to be stored by pointer. This commit does as much of the code motion ahead of time as possible. llvm-svn: 238346
-
Renato Golin authored
Now that most of the methods in Clang and LLVM that were parsing arch/cpu/fpu strings are using ARMTargetParser, it's time to make it a bit more conforming with what the ABI says. This commit adds some clarification on what build attributes are accepted and which are "non-standard". It also makes clear that the "defaultCPU" and "defaultArch" methods were really just build attribute getters. It also diverges from GCC's behaviour to say that armv2/armv3 are really an ARMv4 in the build attributes, when the ABI has a clear state for that: Pre-v4. llvm-svn: 238344
-
Yaron Keren authored
llvm-svn: 238343
-
Alex Lorenz authored
This commit a 3rd attempt at comitting the initial MIR serialization patch. The first commit (r237708) was reverted in 237730. Then the second commit (r237954) was reverted in r238007, as the MIR library under CodeGen caused a circular dependency where the CodeGen library depended on MIR and MIR library depended on CodeGen. This commit has fixed the dependencies between CodeGen and MIR by reorganizing the MIR serialization code - the code that prints out MIR has been moved to CodeGen, and the MIR library has been renamed to MIRParser. Now the CodeGen library doesn't depend on the MIRParser library, thus the circular dependency no longer exists. --Original Commit Message-- MIR Serialization: print and parse LLVM IR using MIR format. This commit is the initial commit for the MIR serialization project. It creates a new library under CodeGen called 'MIR'. This new library adds a new machine function pass that prints out the LLVM IR using the MIR format. This pass is then added as a last pass when a 'stop-after' option is used in llc. The new library adds the initial functionality for parsing of MIR files as well. This commit also extends the llc tool so that it can recognize and parse MIR input files. Reviewers: Duncan P. N. Exon Smith, Matthias Braun, Philip Reames Differential Revision: http://reviews.llvm.org/D9616 llvm-svn: 238341
-
Jan Vesely authored
reviewer: tstellardAMD llvm-svn: 238337
-
Jan Vesely authored
v2: TargetLoweringBase:: -> TargetLowering:: Use Ops array v3: Explicitly use value 0 for ?DIV Remove redundant newline Differential revision: http://reviews.llvm.org/D7803 reviewer: ab llvm-svn: 238336
-
Diego Novillo authored
Counter symbols created for linkonce functions are not discarded by ELF linkers unless the symbols are placed in the same comdat section as its associated function. llvm-svn: 238335
-
Zoran Jovanovic authored
Differential Revision: http://reviews.llvm.org/D9739 llvm-svn: 238333
-
Rafael Espindola authored
llvm-svn: 238332
-
Rafael Espindola authored
llvm-svn: 238331
-
Rafael Espindola authored
llvm-svn: 238330
-
Rafael Espindola authored
llvm-svn: 238329
-
Rafael Espindola authored
llvm-svn: 238328
-
Rafael Espindola authored
llvm-svn: 238327
-
Jozef Kolek authored
This patch implements microMIPS32r6 BEQZALC, BGEZALC, BGTZALC, BLEZALC, BLTZALC and BNEZALC instructions using mapping. Differential Revision: http://reviews.llvm.org/D10031 llvm-svn: 238325
-
Elena Demikhovsky authored
By Igor Breger (igor.breger@intel.com) llvm-svn: 238322
-
Rafael Espindola authored
llvm-svn: 238320
-
Rafael Espindola authored
llvm-svn: 238317
-
Rafael Espindola authored
llvm-svn: 238315
-
Rafael Espindola authored
llvm-svn: 238311
-
Chandler Carruth authored
manager arguments... I have no idea why, but compilers seem to hate this and its late, so I'm not going to debug it. :: sigh :: This is why we can't have nice things. llvm-svn: 238306
-
Chandler Carruth authored
when invoking run methods. This technique was suggested by Dinesh Dwivedi who also wrote the original patch. During the code review, they explained to me that this isn't a fully general technique as we need to know the signatures of the method candidates. Since this is really a narrower utility, I switched the names and structure to be more clearly a specialized run method invoke helper and commented it accordingly. I still think this is a pretty big win. Very sorry to Dinesh for the extreme delay in landing this patch. I've been far to busy poking at other things. Original review: http://reviews.llvm.org/D3543 llvm-svn: 238305
-
Daniel Sanders authored
This broke the llvm-mips-linux builder and several of our out-of-tree builders. Initial investigations show that the commit probably isn't the problem but reverting anyway while I investigate. llvm-svn: 238302
-
Elena Demikhovsky authored
Implemented DAG lowering for all these forms. Added tests for DAG lowering and encoding. By Igor Breger (igor.breger@intel.com) llvm-svn: 238301
-