Skip to content
  1. May 28, 2015
    • Chandler Carruth's avatar
      [omp] Add a configuration variable for the default OpenMP runtime. · cc83ce48
      Chandler Carruth authored
      This will be used in my next commit to Clang.
      
      llvm-svn: 238388
      cc83ce48
    • Duncan P. N. Exon Smith's avatar
      AsmPrinter: Avoid a warning in NDEBUG, NFC · a68b880d
      Duncan P. N. Exon Smith authored
      Should fix the -Werror release build:
      http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/11113
      
      llvm-svn: 238375
      a68b880d
    • Duncan P. N. Exon Smith's avatar
      AsmPrinter: Return added DIE from DIE::addChild() · 6289892c
      Duncan P. N. Exon Smith authored
      Change `DIE::addChild()` to return a reference to the just-added node,
      and update consumers to use it directly.  An upcoming commit will
      abstract away (and eventually change) the underlying storage of
      `DIE::Children`.
      
      llvm-svn: 238372
      6289892c
    • Fiona Glaser's avatar
      RegisterPressure: fix debug prints in case of physical registers · ca706e54
      Fiona Glaser authored
      llvm-svn: 238371
      ca706e54
    • Duncan P. N. Exon Smith's avatar
      AsmPrinter: Stop exposing underlying DIEValue list, NFC · 88a8fc54
      Duncan P. N. Exon Smith authored
      Change the `DIE` API to hide the implementation of the list of
      `DIEValue`s.
      
      llvm-svn: 238369
      88a8fc54
    • Duncan P. N. Exon Smith's avatar
      AsmPrinter: Remove DIEHash::AttrEntry, NFC · f3a6a67f
      Duncan P. N. Exon Smith authored
      Remove "the most boring struct ever" (thanks to review by Eric).
      
      llvm-svn: 238366
      f3a6a67f
    • Duncan P. N. Exon Smith's avatar
      AsmPrinter: Store abbreviation data directly in DIE and DIEValue · 815a6eb5
      Duncan P. N. Exon Smith authored
      Stop storing a `DIEAbbrev` in `DIE`, since the data fits neatly inside
      the `DIEValue` list.  Besides being a cleaner data structure (avoiding
      the parallel arrays), this gives us more freedom to rearrange the
      `DIEValue` list.
      
      This fixes the temporary memory regression from 845 MB up to 879 MB, and
      drops it further to 829 MB for a net memory decrease of around 1.9%
      (incremental decrease around 5.7%).
      
      (I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
      see r236629 for details.)
      
      llvm-svn: 238364
      815a6eb5
    • Duncan P. N. Exon Smith's avatar
      Reapply "AsmPrinter: Change DIEValue to be stored by value" · e7e1d0c7
      Duncan P. N. Exon Smith authored
      This reverts commit r238350, effectively reapplying r238349 after fixing
      (all?) the problems, all somehow related to how I was using
      `AlignedArrayCharUnion<>` inside `DIEValue`:
      
        - MSVC can only handle `sizeof()` on types, not values.  Change the
          assert.
        - GCC doesn't know the `is_trivially_copyable` type trait.  Instead of
          asserting it, add destructors.
        - Call placement new even when constructing POD (i.e., the pointers).
        - Instead of copying the char buffer, copy the casted classes.
      
      I've left in a couple of `static_assert`s that I think both MSVC and GCC
      know how to handle.  If the bots disagree with me, I'll remove them.
      
        - Check that the constructed type is either standard layout or a
          pointer.  This protects against a programming error: we really want
          the "small" `DIEValue`s to be small and simple, so don't
          accidentally change them not to be.
        - Similarly, check that the size of the buffer is no bigger than a
          `uint64_t` or a pointer.  (I thought checking against
          `sizeof(uint64_t)` would be good enough, but Chandler suggested that
          pointers might sometimes be bigger than that in the context of
          sanitizers.)
      
      I've also committed r238359 in the meantime, which introduces a
      DIEValue.def to simplify dispatching between the various types (thanks
      to a review comment by David Blaikie).  Without that, this commit would
      be almost unintelligible.
      
      Here's the original commit message:
      --
      Change `DIEValue` to be stored/passed/etc. by value, instead of
      reference.  It's now a discriminated union, with a `Val` field storing
      the actual type.  The classes that used to inherit from `DIEValue` no
      longer do.  There are two categories of these:
      
        - Small values fit in a single pointer and are stored by value.
        - Large values require auxiliary storage, and are stored by reference.
      
      The only non-mechanical change is to tools/dsymutil/DwarfLinker.cpp.  It
      was relying on `DIEInteger`s being passed around by reference, so I
      replaced that assumption with a `PatchLocation` type that stores a safe
      reference to where the `DIEInteger` lives instead.
      
      This commit causes a temporary regression in memory usage, since I've
      left merging `DIEAbbrevData` into `DIEValue` for a follow-up commit.  I
      measured an increase from 845 MB to 879 MB, around 3.9%.  The follow-up
      drops it lower than the starting point, and I've only recently brought
      the memory this low anyway, so I'm committing these changes separately
      to keep them incremental.  (I also considered swapping the commits, but
      the other one first would cause a lot more code churn.)
      
      (I'm looking at `llc` memory usage on `verify-uselistorder.lto.opt.bc`;
      see r236629 for details.)
      --
      
      llvm-svn: 238362
      e7e1d0c7
  2. May 27, 2015
Loading