Skip to content
  1. Nov 14, 2019
    • Reid Kleckner's avatar
      Sink all InitializePasses.h includes · 05da2fe5
      Reid Kleckner authored
      This file lists every pass in LLVM, and is included by Pass.h, which is
      very popular. Every time we add, remove, or rename a pass in LLVM, it
      caused lots of recompilation.
      
      I found this fact by looking at this table, which is sorted by the
      number of times a file was changed over the last 100,000 git commits
      multiplied by the number of object files that depend on it in the
      current checkout:
        recompiles    touches affected_files  header
        342380        95      3604    llvm/include/llvm/ADT/STLExtras.h
        314730        234     1345    llvm/include/llvm/InitializePasses.h
        307036        118     2602    llvm/include/llvm/ADT/APInt.h
        213049        59      3611    llvm/include/llvm/Support/MathExtras.h
        170422        47      3626    llvm/include/llvm/Support/Compiler.h
        162225        45      3605    llvm/include/llvm/ADT/Optional.h
        158319        63      2513    llvm/include/llvm/ADT/Triple.h
        140322        39      3598    llvm/include/llvm/ADT/StringRef.h
        137647        59      2333    llvm/include/llvm/Support/Error.h
        131619        73      1803    llvm/include/llvm/Support/FileSystem.h
      
      Before this change, touching InitializePasses.h would cause 1345 files
      to recompile. After this change, touching it only causes 550 compiles in
      an incremental rebuild.
      
      Reviewers: bkramer, asbirlea, bollu, jdoerfert
      
      Differential Revision: https://reviews.llvm.org/D70211
      05da2fe5
    • Reid Kleckner's avatar
      Forward declare Optional<T> in STLExtras.h · a36f3163
      Reid Kleckner authored
      WIP stats
      a36f3163
    • Stanislav Mekhanoshin's avatar
      af7d4022
    • Jonas Devlieghere's avatar
      [LLDB] Cleanup the DataEncoder utility. (NFC) · 8ac053ee
      Jonas Devlieghere authored
      This commit removes unused methods from the DataEncoder class and cleans
      up the API by making all the internal methods private.
      8ac053ee
    • Reid Kleckner's avatar
      Revert a hunk from 9634064c · bfe663ce
      Reid Kleckner authored
      This causes errors when building LLDB because the Windows implementation
      doesn't implement this method:
      
      C:\src\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\ScriptInterpreterPython.cpp(915,19): error: allocating an object of abstract class type 'lldb_private::ConnectionGenericFile'
                    new ConnectionGenericFile(read_file, true));
                        ^
      C:\src\llvm-project\lldb\include\lldb/Utility/Connection.h(174,28): note: unimplemented pure virtual method 'GetReadObject' in 'ConnectionGenericFile'
        virtual lldb::IOObjectSP GetReadObject() = 0;
                                 ^
      bfe663ce
    • Jonas Devlieghere's avatar
      [LLDB] Implement pure virtual method in MockConnection · 33c3e0b9
      Jonas Devlieghere authored
      I made GetReadObject pure virtual in the base class and forgot to add
      the method to the mock class.
      33c3e0b9
    • Reid Kleckner's avatar
      Sink MachineFunction private method out of line · 364d1785
      Reid Kleckner authored
      This method is private and only called from this file and doesn't need
      to be inline. Saves a TargetMachine.h include in MachineFunction.h, a
      popular header. The include was introduced in 98603a81 despite the
      forward decl of LLVMTargetMachine.
      364d1785
    • Craig Topper's avatar
      [X86] Don't treat mxcsr as a register name when parsing MS inline assembly. · 188d92b9
      Craig Topper authored
      No instruction takes mxcsr as a an operand so we should always
      treat it as an identifier name.
      188d92b9
    • Jonas Devlieghere's avatar
      [LLDB] Fix another set of -Wdocumentation warnings · 9634064c
      Jonas Devlieghere authored
      At this point I'm just fixing issues as I see them pop up locally in
      incremental builds.
      9634064c
    • Jonas Devlieghere's avatar
      95807cb0
  2. Nov 13, 2019
Loading