Skip to content
  1. May 21, 2021
  2. May 20, 2021
  3. May 19, 2021
  4. May 18, 2021
    • River Riddle's avatar
      [mlir] Allow derived rewrite patterns to define a non-virtual `initialize` hook · 2257e4a7
      River Riddle authored
      This is a hook that allows for providing custom initialization of the pattern, e.g. if it has bounded recursion, setting the debug name, etc., without needing to define a custom constructor. A non-virtual hook was chosen to avoid polluting the vtable with code that we really just want to be inlined when constructing the pattern. The alternative to this would be to just define a constructor for each pattern, this unfortunately creates a lot of otherwise unnecessary boiler plate for a lot of patterns and a hook provides a much simpler/cleaner interface for the very common case.
      
      Differential Revision: https://reviews.llvm.org/D102440
      2257e4a7
    • River Riddle's avatar
      [mlir-lsp-server] Add support for recording text document versions · f9ea3ebe
      River Riddle authored
      The version is used by LSP clients to ignore stale diagnostics, and can be used in a followup to help verify incremental changes.
      
      Differential Revision: https://reviews.llvm.org/D102644
      f9ea3ebe
    • Chris Lattner's avatar
      [IntegerAttr] Add helpers for working with LLVM's APSInt type. · 855b42dd
      Chris Lattner authored
      The FIRRTL dialect in CIRCT uses inherently signful types, and APSInt
      is the best way to model that.  Add a couple of helpers that make it
      easier to work with an IntegerAttr that carries a sign.
      
      This follows the example of getZExt() and getSExt() which assert when
      the underlying type of the attribute is unexpected.  In this case
      we assert fail when the underlying type of the attribute is signless.
      
      This is strictly additive, so it is NFC.  It is tested in the CIRCT
      repo.
      
      Differential Revision: https://reviews.llvm.org/D102701
      855b42dd
    • Chris Lattner's avatar
      [IR] Add a Location to BlockArgument. · 3043be9d
      Chris Lattner authored
      This adds the ability to specify a location when creating BlockArguments.
      Notably Value::getLoc() will return this correctly, which makes diagnostics
      more precise (e.g. the example in test-legalize-type-conversion.mlir).
      
      This is currently optional to avoid breaking any existing code - if
      absent, the BlockArgument defaults to using the location of its enclosing
      operation (preserving existing behavior).
      
      The bulk of this change is plumbing location tracking through the parser
      and printer to make sure it can round trip (in -mlir-print-debuginfo
      mode).  This is complete for generic operations, but requires manual
      adoption for custom ops.
      
      I added support for function-like ops to round trip their argument
      locations - they print correctly, but when parsing the locations are
      dropped on the floor.  I intend to fix this, but it will require more
      invasive plumbing through "function_like_impl" stuff so I think it
      best to split it out to its own patch.
      
      Differential Revision: https://reviews.llvm.org/D102567
      3043be9d
    • Vinayaka Bandishti's avatar
      [MLIR][Affine] Privatize certain escaping memrefs · a3917d36
      Vinayaka Bandishti authored
      During affine loop fusion, create private memrefs for escaping memrefs
      too under the conditions that:
      -- the source is not removed after fusion, and
      -- the destination does not write to the memref.
      
      This creates more fusion opportunities as illustrated in the test case.
      
      Reviewed By: bondhugula, ayzhuang
      
      Differential Revision: https://reviews.llvm.org/D102604
      a3917d36
    • Adrian Kuegel's avatar
      [mlir] Add folder for complex.ReOp and complex.ImOp. · fa765a09
      Adrian Kuegel authored
      Now that complex constants are supported, we can also fold.
      
      Differential Revision: https://reviews.llvm.org/D102616
      fa765a09
    • Rob Suderman's avatar
      [mlir][tosa] Cleanup of tosa.rescale lowering to linalg · a91fb432
      Rob Suderman authored
      Comment was poorly written. Changed to bail on contradictory information in
      the double round.
      
      Reviewed By: NatashaKnk
      
      Differential Revision: https://reviews.llvm.org/D102651
      a91fb432
  5. May 17, 2021
Loading