Skip to content
Snippets Groups Projects
  1. Jul 29, 2019
    • Jinsong Ji's avatar
      [PowerPC][NFC]Fix a typo in comment. · 5bb6202c
      Jinsong Ji authored
      llvm-svn: 367252
      5bb6202c
    • Craig Topper's avatar
    • Puyan Lotfi's avatar
      [compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for xray (2) · a9c59b28
      Puyan Lotfi authored
      Second attempt.
      
      Haven't found a better way to pass the libcxx include path for building
      compiler-rt with libcxx; this seems to be missing only for xray.
      
      Differential Revision: https://reviews.llvm.org/D65307
      
      llvm-svn: 367250
      a9c59b28
    • Reid Kleckner's avatar
      Fix taint-generic.c on Windows, handle case in OS error · 2336c1b8
      Reid Kleckner authored
      llvm-svn: 367249
      2336c1b8
    • Anusha Basana's avatar
      [llvm-lipo] Implement -replace · c94e9511
      Anusha Basana authored
      Replaces specified architecture in universal binary input file with
      slice from the file_name argument passed into the replace command.
      
      Differential Revision: https://reviews.llvm.org/D65247
      
      llvm-svn: 367248
      c94e9511
    • Antonio Afonso's avatar
      Test load unloading of modules with libraries-svr4 · fce59616
      Antonio Afonso authored
      Summary:
      This doubles the 3 tests running right now on linux by also executing each test with libraries-svr4 enabled.
      Not sure if there's a better way to do this as I had to copy/paste all the decorators as well...
      
      Reviewers: labath, clayborg, xiaobai
      
      Reviewed By: labath
      
      Subscribers: srhines, lldb-commits
      
      Tags: #lldb
      
      Differential Revision: https://reviews.llvm.org/D65129
      
      llvm-svn: 367247
      fce59616
    • Puyan Lotfi's avatar
      5bf16ec0
    • Vitaly Buka's avatar
      gn build: Merge r367071 · 9dfed83e
      Vitaly Buka authored
      > llvm-svn: 366289
      
      llvm-svn: 367245
      9dfed83e
    • David Bolvansky's avatar
      [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option · 45be5e47
      David Bolvansky authored
      Summary:
      The script is silent for the following issue:
      FileCheck %s -check-prefix=CHECK,POPCOUNT
      
      FileCheck will catch it later, but I think we can warn here too.
      
      Now it warns:
       ./update_llc_test_checks.py file.ll 
      WARNING: Supplied prefix 'CHECK,POPCOUNT' is invalid. Prefix must contain only alphanumeric characters, hyphens and underscores. Did you mean --check-prefixes=CHECK,POPCOUNT?
      
      
      
      Reviewers: lebedev.ri, spatel, RKSimon, craig.topper, nikic, gbedwell
      
      Reviewed By: RKSimon
      
      Subscribers: llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D64589
      
      llvm-svn: 367244
      45be5e47
    • Francis Visoiu Mistrih's avatar
      [Remarks] Update error message format string · 72d00802
      Francis Visoiu Mistrih authored
      All the clang-cmake-armv{7,8} bots are failing this test. This is an
      attempt to fix this.
      
      llvm-svn: 367243
      72d00802
    • Peter Collingbourne's avatar
      ThinLTOBitcodeWriter: Include globals associated with type metadata globals in the merged module. · dd968219
      Peter Collingbourne authored
      Globals that are associated with globals with type metadata need to appear
      in the merged module because they will reference the global's section directly.
      
      Differential Revision: https://reviews.llvm.org/D65312
      
      llvm-svn: 367242
      dd968219
    • Jordan Rupprecht's avatar
      [lldb] Qualify includes of Properties[Enum].inc files. NFC · 6a253d37
      Jordan Rupprecht authored
      Summary:
      This is a bit more explicit, and makes it possible to build LLDB without
      varying the -I lines per-directory.
      (The latter is useful because many build systems only allow this to be
      configured per-library, and LLDB is insufficiently layered to be split into
      multiple libraries on stricter build systems).
      
      (My comment on D65185 has some more context)
      
      Reviewers: JDevlieghere, labath, chandlerc, jdoerfert
      
      Reviewed By: labath
      
      Subscribers: mgorny, lldb-commits
      
      Tags: #lldb
      
      Differential Revision: https://reviews.llvm.org/D65397
      
      Patch by Sam McCall!
      
      llvm-svn: 367241
      6a253d37
    • Simon Pilgrim's avatar
      [X86] resolveTargetShuffleInputs - add depth to limit recursion. · 962c03fa
      Simon Pilgrim authored
      Avoids slow downs from calls to ComputeNumSignBits/computeKnownBits going too deep.
      
      llvm-svn: 367240
      962c03fa
    • Puyan Lotfi's avatar
      Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray · ba7b7f1d
      Puyan Lotfi authored
      Haven't found a better way to pass the libcxx include path for building
      compiler-rt with libcxx; this seems to be missing only for xray.
      
      Differential Revision: https://reviews.llvm.org/D65307
      
      llvm-svn: 367239
      ba7b7f1d
    • Jonas Devlieghere's avatar
      [lldb] Also include the array definition in Properties.inc · a8ea5955
      Jonas Devlieghere authored
      Right now our Properties.inc only generates the initializer for the
      options list but not the array declaration boilerplate around it. As the
      array definition is identical for all arrays, we might as well also let
      the Properties.inc generate it alongside the initializers.
      
      Unfortunately we cannot do the same for enums, as there's this magic
      ePropertyExperimental, which needs to come at the end to be interpreted
      correctly. Hopefully we can get rid of this in the future and do the
      same for the property enums.
      
      Differential revision: https://reviews.llvm.org/D65353
      
      llvm-svn: 367238
      a8ea5955
    • Tom Stellard's avatar
      AMDGPU/LoadStoreOptimizer: combine MMOs when merging instructions · cc0bc941
      Tom Stellard authored
      Summary:
      The LoadStoreOptimizer was creating instructions with 2
      MachineMemOperands, which meant they were assumed to alias with all other instructions,
      because MachineInstr:mayAlias() returns true when an instruction has multiple
      MachineMemOperands.
      
      This was preventing these instructions from being merged again, and was
      giving the scheduler less freedom to reorder them.
      
      Reviewers: arsenm, nhaehnle
      
      Reviewed By: arsenm
      
      Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D65036
      
      llvm-svn: 367237
      cc0bc941
    • Sergey Dmitriev's avatar
      [llvm-objcopy] Improve --add-section argument string parsing · 899bdaa8
      Sergey Dmitriev authored
      Differential Revision: https://reviews.llvm.org/D65346
      
      llvm-svn: 367236
      899bdaa8
    • Jay Foad's avatar
      [AMDGPU] Fix typo in error message · 3bdcedbf
      Jay Foad authored
      llvm-svn: 367235
      3bdcedbf
    • Jan Kratochvil's avatar
      [lldb] Increase testsuite packet-timeout 5secs -> 1min · 2b389517
      Jan Kratochvil authored
      rL357954 did increase `packet-timeout` 1sec -> 5secs. Which is IMO about the
      maximum timeout reasonable for regular use. But for testsuite I think the
      timeout should be higher as the testsuite runs in parallel and it can be run
      even on slow hosts and with other load (moreover if it runs on some slow arch).
      
      I have chosen 60 secs, that should be enough hopefully.  Larger value could
      make debugging with hanging `lldb-server` annoying.
      
      This patch was based on this testsuite timeout:
      http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/546/steps/test/logs/stdio
      	FAIL: test_connect (TestGDBRemoteClient.TestGDBRemoteClient)
      	   Test connecting to a remote gdb server
      	----------------------------------------------------------------------
      	Traceback (most recent call last):
      	  File "/home/jkratoch/slave-lldb-x86_64-fedora/lldb-x86_64-fedora/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py", line 13, in test_connect
      	    process = self.connect(target)
      	  File "/home/jkratoch/slave-lldb-x86_64-fedora/lldb-x86_64-fedora/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py", line 480, in connect
      	    self.assertTrue(error.Success(), error.description)
      	AssertionError: False is not True : failed to get reply to handshake packet
      
      Differential Revision: https://reviews.llvm.org/D65271
      
      llvm-svn: 367234
      2b389517
    • Cameron McInally's avatar
      b32a6592
    • Simon Pilgrim's avatar
      [X86] combineX86ShufflesRecursively - start recursion at depth = 0. NFCI. · 5ab948f8
      Simon Pilgrim authored
      As discussed on rL367171, we have a problem where the depth recursion used in combineX86ShufflesRecursively was subtly different to computeKnownBits etc. - it starts at Depth=1 instead of Depth=0 like the others and has a different maximum recursion depth.
      
      This NFC patch fixes the recursion depth to start at 0, so we can more easily reuse depth values in calls from combineX86ShufflesRecursively and its helper functions in computeKnownBits etc.
      
      llvm-svn: 367232
      5ab948f8
    • Pavel Labath's avatar
      SymbolVendor: Make SectionAddressesChanged a passthrough · c2409baa
      Pavel Labath authored
      Summary:
      This moves the implementation of the function into the SymbolFile class,
      making it possible to excise the SymbolVendor passthrough functions in
      follow-up patches.
      
      Reviewers: clayborg, jingham, JDevlieghere
      
      Subscribers: lldb-commits
      
      Differential Revision: https://reviews.llvm.org/D65266
      
      llvm-svn: 367231
      c2409baa
    • Francis Visoiu Mistrih's avatar
      [RISCV] Fix uninitialized variable after call to evaluateConstantImm · d42289e2
      Francis Visoiu Mistrih authored
      For llvm/test/MC/RISCV/rv64i-aliases-invalid.s, UBSan reports:
      
      lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:371:9: runtime error:
      load of value 3879186881, which is not a valid value for type
      'RISCVMCExpr::VariantKind'
      SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
      lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:371:9 in
      
      It turns out that evaluateConstantImm does not set `VK` and it remains
      unitialized when doing comparisons in `isImmXLenLI()`.
      
      Differential Revision: https://reviews.llvm.org/D65347
      
      llvm-svn: 367230
      d42289e2
    • Sven van Haastregt's avatar
      [OpenCL] Rename builtin definition classes · 89fb9e8c
      Sven van Haastregt authored
      Factor out some of the renames from D63434 and D63442, and generate
      half type convert_ builtins.
      
      Patch by Pierre Gondois and Sven van Haastregt.
      
      llvm-svn: 367229
      89fb9e8c
    • Michal Gorny's avatar
      [lldb] [test] Mark three new tests XFAIL on NetBSD · e0ab4c8e
      Michal Gorny authored
      llvm-svn: 367228
      e0ab4c8e
    • Sanjay Patel's avatar
      [InstCombine] fold fadd+fneg with fdiv/fmul betweena · e9ee7b47
      Sanjay Patel authored
      The backend already does this via isNegatibleForFree(),
      but we may want to alter the fneg IR canonicalizations
      that currently exist, so we need to try harder to fold
      fneg in IR to avoid regressions.
      
      llvm-svn: 367227
      e9ee7b47
    • Hideto Ueno's avatar
      [ValueTracking] Remove volatile check in isGuaranteedToTransferExecutionToSuccessor · 98d281a9
      Hideto Ueno authored
      Summary: As clarified in D53184, volatile load and store do not trap. Therefore, we should remove volatile checks for instructions in  `isGuaranteedToTransferExecutionToSuccessor`.
      
      Reviewers: jdoerfert, efriedma, nikic
      
      Reviewed By: nikic
      
      Subscribers: hiraditya, jfb, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D65375
      
      llvm-svn: 367226
      98d281a9
    • Nico Weber's avatar
      clang-format clang/lib/Format · ff9f4b54
      Nico Weber authored
      llvm-svn: 367225
      ff9f4b54
    • Sanjay Patel's avatar
      [InstCombine] reduce code for fadd with fneg operand; NFC · 5483f422
      Sanjay Patel authored
      llvm-svn: 367224
      5483f422
    • Sanjay Patel's avatar
      [InstCombine] add tests for fadd with negated operand; NFC · 74c35bd6
      Sanjay Patel authored
      llvm-svn: 367222
      74c35bd6
    • Jay Foad's avatar
      [AMDGPU] Add amdgpu_kernel for consistency with other tests · 2bd9da8a
      Jay Foad authored
      llvm-svn: 367221
      2bd9da8a
    • Simon Pilgrim's avatar
      [DAGCombine] narrowInsertExtractVectorBinOp - early out for binops that change value type. NFCI. · f8a7e9de
      Simon Pilgrim authored
      This is implicit in the value type checks in getSubVectorSrc - this just makes it upfront and obvious.
      
      llvm-svn: 367220
      f8a7e9de
    • Rafael Stahl's avatar
      doc: Fix Google C++ Style Guide link. · 0e074fa0
      Rafael Stahl authored
      llvm-svn: 367219
      0e074fa0
    • Jay Foad's avatar
      [DivergenceAnalysis] Add methods for querying divergence at use · dcb75324
      Jay Foad authored
      Summary:
      The existing isDivergent(Value) methods query whether a value is
      divergent at its definition. However even if a value is uniform at its
      definition, a use of it in another basic block can be divergent because
      of divergent control flow between the def and the use.
      
      This patch adds new isDivergent(Use) methods to DivergenceAnalysis,
      LegacyDivergenceAnalysis and GPUDivergenceAnalysis.
      
      This might allow D63953 or other similar workarounds to be removed.
      
      Reviewers: alex-t, nhaehnle, arsenm, rtaylor, rampitec, simoll, jingyue
      
      Reviewed By: nhaehnle
      
      Subscribers: jfb, jvesely, wdng, hiraditya, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D65141
      
      llvm-svn: 367218
      dcb75324
    • Simon Pilgrim's avatar
      [SystemZ] Regenerate <8 x i31> store test · a4f08dde
      Simon Pilgrim authored
      To help show the diffs from an upcoming SimplifyDemandedBits patch.
      
      llvm-svn: 367216
      a4f08dde
    • Hans Wennborg's avatar
      Mark test/MC/RISCV/rv{32,64}i-aliases-invalid.s unsupported also on Windows · ecd137c7
      Hans Wennborg authored
      Because they fail there too.
      
      FAIL: LLVM :: MC/RISCV/rv32i-aliases-invalid.s (24397 of 32659)
      ******************** TEST 'LLVM :: MC/RISCV/rv32i-aliases-invalid.s' FAILED ********************
      Script:
      --
      : 'RUN: at line 2';   not c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s -triple=riscv32 -riscv-no-aliases 2>&1 | c:\src\llvm.monorepo\build.release2\bin\filecheck.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s
      : 'RUN: at line 3';   not c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s -triple=riscv32 2>&1 | c:\src\llvm.monorepo\build.release2\bin\filecheck.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s
      --
      Exit Code: 1
      
      Command Output (stdout):
      --
      $ ":" "RUN: at line 2"
      $ "not" "c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe" "C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s" "-triple=riscv32" "-riscv-no-aliases"
      $ "c:\src\llvm.monorepo\build.release2\bin\filecheck.exe" "C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s"
      C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv32i-aliases-invalid.s:10:21: error: CHECK: expected string not found in input
      li t4, foo # CHECK: :[[@LINE]]:8: error: immediate must be an integer in the range [-2147483648, 4294967295]
                          ^
      <stdin>:5:1: note: scanning from here
      li x0, -2147483649 # CHECK: :[[@LINE]]:8: error: immediate must be an integer in the range [-2147483648, 4294967295]
      ^
      <stdin>:5:1: note: with "@LINE" equal to "10"
      li x0, -2147483649 # CHECK: :[[@LINE]]:8: error: immediate must be an integer in the range [-2147483648, 4294967295]
      ^
      <stdin>:5:38: note: possible intended match here
      li x0, -2147483649 # CHECK: :[[@LINE]]:8: error: immediate must be an integer in the range [-2147483648, 4294967295]
                                           ^
      
      error: command failed with exit status: 1
      
      --
      
      --
      ********************
      Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70
      FAIL: LLVM :: MC/RISCV/rv64i-aliases-invalid.s (24416 of 32659)
      ******************** TEST 'LLVM :: MC/RISCV/rv64i-aliases-invalid.s' FAILED ********************
      Script:
      --
      : 'RUN: at line 2';   not c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s -triple=riscv64 -riscv-no-aliases 2>&1 | c:\src\llvm.monorepo\build.release2\bin\filecheck.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s
      : 'RUN: at line 3';   not c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s -triple=riscv64 2>&1 | c:\src\llvm.monorepo\build.release2\bin\filecheck.exe C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s
      --
      Exit Code: 1
      
      Command Output (stdout):
      --
      $ ":" "RUN: at line 2"
      $ "not" "c:\src\llvm.monorepo\build.release2\bin\llvm-mc.exe" "C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s" "-triple=riscv64" "-riscv-no-aliases"
      $ "c:\src\llvm.monorepo\build.release2\bin\filecheck.exe" "C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s"
      C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s:6:21: error: CHECK: expected string not found in input
      li t4, foo # CHECK: :[[@LINE]]:8: error: operand must be a constant 64-bit integer
                          ^
      <stdin>:2:1: note: scanning from here
      li t5, 0x10000000000000000 # CHECK: :[[@LINE]]:8: error: unknown operand
      ^
      <stdin>:2:1: note: with "@LINE" equal to "6"
      li t5, 0x10000000000000000 # CHECK: :[[@LINE]]:8: error: unknown operand
      ^
      <stdin>:13:67: note: possible intended match here
      C:\src\llvm.monorepo\llvm\test\MC\RISCV\rv64i-aliases-invalid.s:12:13: error: immediate must be an integer in the range [0, 63]
                                                                        ^
      
      error: command failed with exit status: 1
      llvm-svn: 367215
      ecd137c7
    • Simon Pilgrim's avatar
      [ARM] Regenerate rotation tests · adda256a
      Simon Pilgrim authored
      llvm-svn: 367214
      adda256a
    • Simon Pilgrim's avatar
      [AMDGPU] Regenerate v2i16 insertelement tests. · 251b546f
      Simon Pilgrim authored
      To help show the diffs from an upcoming SimplifyDemandedBits patch.
      
      llvm-svn: 367213
      251b546f
    • Sam Parker's avatar
      [NFC][ARM[ParallelDSP] Cleanup of BinOpChain · 414dd1c9
      Sam Parker authored
      - Remove some unused typedefs.
      - Rename BinOpChain struct to MulCandidate.
      - Remove the size method of MulCandidate.
      - Store only the first input of the ValueList provided to
        MulCandidate, as it's the only value we care about. This means we
        don't have to perform any ugly (and unnecessary) iterations of the 
        list later on.
      
      llvm-svn: 367208
      414dd1c9
    • Raphael Isemann's avatar
      [lldb][NFC] Split emitting and parsing in LLDBOptionDefEmitter · 4e44c77a
      Raphael Isemann authored
      Splitting the different logic is cleaner and we it will be easier
      to implement the enum emitting (which otherwise would have to
      reimplement the Record parsing).
      
      llvm-svn: 367207
      4e44c77a
Loading