- Feb 25, 2020
-
-
Shoaib Meenai authored
When you run `arc diff`, arc defaults to uploading all the changes you have against the upstream branch into a single patch. This is almost never what you want for stacked commits (patch series); you only want to submit the changes done by the current patch. It's also come up as a point of confusion in the Phabricator vs. GitHub PRs discussion, for example. Configure arc to only upload your current patch by default, which I think is a much more suitable default for LLVM developers. Differential Revision: https://reviews.llvm.org/D74990
-
Jason Molenda authored
Fix RegisterContextLLDB::InitializeNonZerothFrame so that it will fetch a FullUnwindPlan instead of falling back to the architectural default unwind plan -- GetFullUnwindPlan knows how to spot a jmp 0x0 that results in a fault, which may be the case when we see a trap handler on the stack. Fix RegisterContextLLDB::SavedLocationForRegister so that when the pc value is requested from a trap handler frame, where we have a complete register context available to us, don't provide the Return Address register (lr) instead of the pc. We have an actual pc value here, and it's pointing to the instruction that faulted. Differential revision: https://reviews.llvm.org/D75007 <rdar://problem/59416588>
-
Nathan James authored
Summary: Remove `internal::Matcher` and `internal::BindableMatcher` from Result Type when dumping AST Matchers Reviewers: joerg, gribozavr2, aaron.ballman Reviewed By: aaron.ballman Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D75046
-
Jonas Devlieghere authored
Highlight the color marker similar to what we do for the column marker. The default color matches the color of the current PC marker (->) in the default disassembly format. Differential revision: https://reviews.llvm.org/D75070
-
Craig Topper authored
Should fix PR42803 and PR44902 Differential Revision: https://reviews.llvm.org/D74590
-
Jay Foad authored
Summary: Add more test cases for signed and unsigned add/sub with overflow. Reviewers: arsenm, rampitec, kerbowa Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, dstuttard, tpr, t-tye, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75051
-
- Feb 24, 2020
-
-
Alex Brachet authored
Summary: This patch adds `EXPECT_EXITS` and `EXPECT_DEATH` macros for testing exit codes and deadly signals. They are less convoluted than their analogs in GTEST and don't have matchers but just take an int for either the exit code or the signal respectively. Nor do they have any regex match against the stdout/stderr of the child process. Reviewers: sivachandra, gchatelet Reviewed By: sivachandra Subscribers: mgorny, MaskRay, tschuett, libc-commits Differential Revision: https://reviews.llvm.org/D74665
-
Med Ismail Bennani authored
This patch moves the SB API method GetExtendedCrashInformation from SBTarget to SBProcess since it only makes sense to call this method on a sane process which might not be the case on a SBTarget object. It also addresses some feedbacks received after landing the first patch for the 'crash-info' feature. Differential Revision: https://reviews.llvm.org/D75049 Signed-off-by:
Med Ismail Bennani <medismail.bennani@gmail.com>
-
Bardia Mahjour authored
Summary: This patch moves the getIndexExpressionsFromGEP function from polly into ScalarEvolution so that both polly and DependenceAnalysis can use it for the purpose of subscript delinearization when the array sizes are not parametric. Authored By: bmahjour Reviewer: Meinersbur, sebpop, fhahn, dmgreen, grosser, etiotto, bollu Reviewed By: Meinersbur Subscribers: hiraditya, arphaman, Whitney, ppc-slack, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D73995
-
zoecarver authored
Verifies that the argument passed to __builtin_frame_address and __builtin_return_address is within the range [0, 0xFFFF].
-
Greg Clayton authored
Summary: These modificaitons will be used in D74883. Fixed length C strings can have trailing NULLs or sometimes spaces (BSD archive files), so the fixed length C string defaults to stripping trailing NULLs, but can have the arguments specify to remove one or more kinds of spaces if needed. This is used to extract fixed length C strings from ELF NOTEs in D74883. Reviewers: labath, dblaikie, aprantl Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D74991
-
Jonas Devlieghere authored
-
Ikhlas Ajbar authored
This patch lowers store of vector predicate of type v128i1.
-
Eric Astor authored
This reverts commit 9fe769a9, and re-lands commit c2e272f8. Summary: Add support for ?, DUP, and string initializers, as well as MASM syntax for named data locations. This version avoids the use of a C++17-only feature, if-statements with initializer. Reviewers: rnk, thakis Reviewed By: thakis Tags: #llvm Differential Revision: https://reviews.llvm.org/D73226
-
Roman Tereshin authored
Depending on the target, test suite, pipeline config and perhaps other factors machine verifier when forced on with -verify-machineinstrs can increase compile time 2-2.5 times over (Release, Asserts On), taking up ~60% of the time. An invaluable tool, it significantly slows down machine verifier-enabled testing. Nearly 75% of its time MachineVerifier spends in the calcRegsPassed method. It's a classic forward dataflow analysis executed over sets, but visiting MBBs in arbitrary order. We switch that to RPO here. This speeds up MachineVerifier by about 35%, decreasing the overall compile time with -verify-machineinstrs by 20-25% or so. calcRegsPassed itself gets 2x faster here. All measured on a large suite of shaders targeting a number of GPUs. Reviewers: bogner, stoklund, rudkx, qcolombet Reviewed By: bogner Tags: #llvm Differential Revision: https://reviews.llvm.org/D75032
-
Ikhlas Ajbar authored
This patch lowers bitcast of vector predicate of type v32i1/v64i1 to i32/i64 type.
-
Eric Astor authored
This reverts commit c2e272f8, which broke builds.
-
Jonas Devlieghere authored
Differential revision: https://reviews.llvm.org/D75073
-
Jonas Devlieghere authored
The DEFAULT_ were used in property definitions which have since been moved to CoreProperties.td.
-
Eric Astor authored
Summary: Add support for ?, DUP, and string initializers, as well as MASM syntax for named data locations. Reviewers: rnk, thakis Reviewed By: thakis Subscribers: merge_guards_bot, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D73226
-
nmostafa authored
-
Craig Topper authored
Previously we emitted an fmadd and a fmadd+fneg and combined them with a shufflevector. But this doesn't follow the correct exception behavior for unselected elements so the backend can't merge them into the fmaddsub/fmsubadd instructions. This patch restores the the fmaddsub intrinsics so we don't have two arithmetic operations. We lose out on optimization opportunity in the non-strict FP case, but I don't think this is a big loss. If someone gives us a test case we can look into adding instcombine/dagcombine improvements. I'd rather not have the frontend do completely different things for strict and non-strict. This still has problems because target specific intrinsics don't support strict semantics yet. We also still have all of the problems with masking. But we at least generate the right instruction in constrained mode now. Differential Revision: https://reviews.llvm.org/D74268
-
Stanislav Mekhanoshin authored
GCC 9.2 seems to incorrectly issue warning about out of bounds access. This situation should not happen in any way. Differential Revision: https://reviews.llvm.org/D75071
-
Raphael Isemann authored
https://reviews.llvm.org/D68480 added those headers and made the std module only usable with C++14 or later as the submodules were not marked as requiring C++14 or later. This just adds the missing requires directives.
-
Lei Zhang authored
Previously C++ test passes for SPIR-V were put under test/Dialect/SPIRV. Move them to test/lib/Dialect/SPIRV to create a better structure. Also fixed one of the test pass to use new PassRegistration mechanism. Differential Revision: https://reviews.llvm.org/D75066
-
Ayke van Laethem authored
This patch adds bindings to C and Go for addCoroutinePassesToExtensionPoints, which is used to add coroutine passes to the correct locations in PassManagerBuilder. Differential Revision: https://reviews.llvm.org/D51642
-
Simon Pilgrim authored
This is the second patch as part of https://bugs.llvm.org/show_bug.cgi?id=36544 Merging in the ConstantSDNode variant of FoldConstantArithmetic. After this, I will begin merging in FoldConstantVectorArithmetic I've ensured this patch can build & pass all lit tests in Windows and Linux environments. Patch by @justice_adams (Justice Adams) Differential Revision: https://reviews.llvm.org/D74881
-
Francis Visoiu Mistrih authored
Add checks for triples that don't use mach-o, and unit tests for everything.
-
Ayke van Laethem authored
This allows removing instructions without erasing them. They can then be added somewhere else in the IR using Builder.Insert().
-
Ayke van Laethem authored
Simply by implementing a few functions I was able to correctly disassemble a much larger amount of instructions. Differential Revision: https://reviews.llvm.org/D74045
-
Simon Pilgrim authored
Noticed by inspection, we shouldn't use FloatDomain directly, we've already bitcast both inputs to MaskVT so select the opcode using that.
-
Ayke van Laethem authored
Not all operands are correctly disassembled at the moment. This means that some machine instructions won't have all the necessary operands set. To avoid asserting, print an error instead until the necessary support has been implemented. Differential Revision: https://reviews.llvm.org/D73958
-
Ayke van Laethem authored
A number of multiplication instructions (muls, mulsu, fmul, fmuls, fmulsu) had the wrong register class for an operand. This resulted in the wrong register being used for the instruction. Example: target datalayout = "e-P1-p:16:8-i8:8-i16:8-i32:8-i64:8-f32:8-f64:8-n8-a:8" target triple = "avr-atmel-none" define i16 @sliceAppend(i16, i16, i16, i16, i16, i16) addrspace(1) { %d = mul i16 %0, %5 ret i16 %d } The first instruction would be muls r24, r31 before this patch. The r31 should have been r15 if you look at the intermediate forms during instruction selection / register allocation, but the generated instruction uses r31. After this patch, an extra movw is inserted to get %5 in range for muls. To make sure this bug is fixed everywhere, I checked all instructions and found that most multiplication instructions suffered from this bug, which I have fixed with this patch. No other instructions appear to be affected. Differential Revision: https://reviews.llvm.org/D74281
-
jasonliu authored
Summary: Function descriptor csect on AIX should be 4 byte align instead of 1 byte align. Reviewer: daltenty Differential Revision: https://reviews.llvm.org/D74974
-
Michael Kruse authored
Pass plugins introduced in D61446 do not support dynamic linking on Windows, hence the option LLVM_${name_upper}_LINK_INTO_TOOLS can only work being set to "ON". Currently, it defaults to "OFF" such that such plugins are inoperable by default on Windows. Change the default for subprojects to follow LLVM_ENABLE_PROJECTS. Reviewed By: serge-sans-paille, MaskRay Differential Revision: https://reviews.llvm.org/D72372
-
Francesco Petrogalli authored
Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D74969
-
Louis Dionne authored
We always build all components of libc++ with -std=c++14 anyway
-
serge-sans-paille authored
-
Peter Collingbourne authored
And add llvm-go back to the test dependencies. No longer necessary now that llvm-go has been brought back. This reverts commit e8f8873d.
-